Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go 1.20 and newer protobuf builder to reduce v50 changeset #3811

Merged
merged 14 commits into from
Jun 13, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 10, 2023

This PR uses go 1.20 and the latest protobuf builder so that the changeset for
v50 is smaller. This is the same intent as the earlier thelper PR, basically to
reduce the total number of changes that will be present in the v50 pr.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @faddat! I think it would be nice to take out the bump to SDK v0.47.3 out of this PR (since you have that covered in #3810) and then the scope of this PR will very nicely be scope to bumping go version and protobuf builder version. :)

If these are changes required for SDK v0.50. Should we target this PR to the feature branch?

@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

Hey Carlos, I'm very happy to do that. I will take care of that right now.

@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

...btw I do have a question -- I could not really figure out why the capabilities module does not build here, do you have any ideas?

@faddat faddat marked this pull request as ready for review June 12, 2023 05:26
@crodriguezvega
Copy link
Contributor

I could not really figure out why the capabilities module does not build here, do you have any ideas?

Looks like it's building now, right?

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you, @faddat!

.github/workflows/capability.yml Outdated Show resolved Hide resolved
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @faddat, lgtm!

.github/workflows/capability.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

I'll make it single quotes because following the recommendations is great :)

@colin-axner
Copy link
Contributor

colin-axner commented Jun 12, 2023

Hi, was this commit dd3b04b supposed to turn the quotes into single quotes or is the intention to do it in a followup commit?

@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

Hey Colin, yeah that was definitely supposed to be single quotes and I think that I should just revert that commit, I'm not sure how it ended up that way

Thanks for your review!

@faddat
Copy link
Contributor Author

faddat commented Jun 12, 2023

So what ended up being necessary was just reconfiguring my editor to use single quotes in YAML by default.

When I did the flub commit before, it was because my editor was changing the singles to doubles when I saved the file.

@crodriguezvega crodriguezvega merged commit 7893863 into cosmos:main Jun 13, 2023
@faddat faddat mentioned this pull request Jun 18, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants