Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

begin math lib transition #3835

Merged
merged 10 commits into from
Jun 16, 2023
Merged

begin math lib transition #3835

merged 10 commits into from
Jun 16, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 13, 2023

This PR will contain all of the changes made to the use of sdk.* to math.*

@crodriguezvega
Copy link
Contributor

We recently merged a PR to use sdkmath as import alias for cosmossdk.io/math to avoid confusion with the built in math package. Can you please use the same convention here? 🙏

@faddat
Copy link
Contributor Author

faddat commented Jun 14, 2023

Absolutely 🙂

@faddat
Copy link
Contributor Author

faddat commented Jun 15, 2023

Note on the conventions being established here in ibc-go -- I took errorsmod and ported it to the ecosystem :)

It's good :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #3835 (edab104) into main (7850184) will not change coverage.
The diff coverage is 100.00%.

❗ Current head edab104 differs from pull request most recent head bbe2b02. Consider uploading reports for the commit bbe2b02 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3835   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files         187      187           
  Lines       12939    12939           
=======================================
  Hits        10206    10206           
  Misses       2305     2305           
  Partials      428      428           
Impacted Files Coverage Δ
modules/apps/transfer/keeper/keeper.go 90.47% <100.00%> (ø)
modules/apps/transfer/keeper/relay.go 90.90% <100.00%> (ø)
modules/apps/transfer/types/packet.go 100.00% <100.00%> (ø)
...ules/apps/transfer/types/transfer_authorization.go 92.04% <100.00%> (ø)

@faddat faddat marked this pull request as ready for review June 15, 2023 08:08
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, dope 🚀

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @DimitrisJim: this is dope! 👍 Thanks, @faddat!

@faddat
Copy link
Contributor Author

faddat commented Jun 16, 2023

Thanks to @tac0turtle too, was his idea :)

@crodriguezvega crodriguezvega merged commit eab9fb5 into cosmos:main Jun 16, 2023
@faddat faddat mentioned this pull request Jun 18, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants