-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
begin math lib transition #3835
Conversation
We recently merged a PR to use |
Absolutely 🙂 |
Note on the conventions being established here in ibc-go -- I took errorsmod and ported it to the ecosystem :) It's good :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3835 +/- ##
=======================================
Coverage 78.87% 78.87%
=======================================
Files 187 187
Lines 12939 12939
=======================================
Hits 10206 10206
Misses 2305 2305
Partials 428 428
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt, dope 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @DimitrisJim: this is dope! 👍 Thanks, @faddat!
Thanks to @tac0turtle too, was his idea :) |
This PR will contain all of the changes made to the use of sdk.* to math.*