feat: scalable version queries

docs/ibc/proto-docs.md

@@ -189,6 +189,12 @@
 
     - [Msg](#ibc.core.connection.v1.Msg)
 
+- [ibc/core/port/v1/query.proto](#ibc/core/port/v1/query.proto)
+    - [QueryPortRequest](#ibc.core.port.v1.QueryPortRequest)
+    - [QueryPortResponse](#ibc.core.port.v1.QueryPortResponse)
+
+    - [Query](#ibc.core.port.v1.Query)
+
 - [ibc/core/types/v1/genesis.proto](#ibc/core/types/v1/genesis.proto)
     - [GenesisState](#ibc.core.types.v1.GenesisState)
 
@@ -2874,6 +2880,65 @@ Msg defines the ibc/connection Msg service.
 
 
 
+<a name="ibc/core/port/v1/query.proto"></a>
+<p align="right"><a href="#top">Top</a></p>
+
+## ibc/core/port/v1/query.proto
+
+
+
+<a name="ibc.core.port.v1.QueryPortRequest"></a>
+
+### QueryPortRequest
+QueryPortRequest is the request type for the Query/Port RPC method
+
+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| `port_id` | [string](#string) |  | port unique identifier |
+| `counterparty` | [ibc.core.channel.v1.Counterparty](#ibc.core.channel.v1.Counterparty) |  | counterparty channel end |
+| `counterparty_version` | [string](#string) |  | counterparty version |
+
+
+
+
+
+
+<a name="ibc.core.port.v1.QueryPortResponse"></a>
+
+### QueryPortResponse
+QueryPortResponse is the response type for the Query/Port RPC method.
+
+
+| Field | Type | Label | Description |
+| ----- | ---- | ----- | ----------- |
+| `port_id` | [string](#string) |  | port id associated with the request identifiers |
+| `version` | [string](#string) |  | supported app version |
+
+
+
+
+
+ <!-- end messages -->
+
+ <!-- end enums -->
+
+ <!-- end HasExtensions -->
+
+
+<a name="ibc.core.port.v1.Query"></a>
+
+### Query
+Query provides defines the gRPC querier service
+
+| Method Name | Request Type | Response Type | Description | HTTP Verb | Endpoint |
+| ----------- | ------------ | ------------- | ------------| ------- | -------- |
+| `Port` | [QueryPortRequest](#ibc.core.port.v1.QueryPortRequest) | [QueryPortResponse](#ibc.core.port.v1.QueryPortResponse) | Port queries an IBC Port. | |
+
+ <!-- end services -->
+
+
+
 <a name="ibc/core/types/v1/genesis.proto"></a>
 <p align="right"><a href="#top">Top</a></p>
 

modules/apps/transfer/module.go

@@ -434,3 +434,17 @@ func (am AppModule) OnTimeoutPacket(
 
 	return nil
 }
+
+// NegotiateAppVersion implements the IBCModule interface
+func (am AppModule) NegotiateAppVersion(
+	ctx sdk.Context,
+	portID string,
+	counterparty channeltypes.Counterparty,
+	counterpartyVersion string,
+) (version string, err error) {
+	if counterpartyVersion != types.Version {
+		return "", sdkerrors.Wrapf(types.ErrInvalidVersion, "invalid counterparty version: got: %s, expected %s", counterpartyVersion, types.Version)
+	}
+
+	return types.Version, nil
+}

modules/core/05-port/client/cli/cli.go

@@ -0,0 +1,25 @@
+package cli
+
+import (
+	"github.com/spf13/cobra"
+
+	"github.com/cosmos/cosmos-sdk/client"
+	"github.com/cosmos/ibc-go/modules/core/05-port/types"
+)
+
+// GetQueryCmd returns the query commands for IBC channels
+func GetQueryCmd() *cobra.Command {
+	queryCmd := &cobra.Command{
+		Use:                        types.SubModuleName,
+		Short:                      "IBC port query subcommands",
+		DisableFlagParsing:         true,
+		SuggestionsMinimumDistance: 2,
+		RunE:                       client.ValidateCmd,
+	}
+
+	queryCmd.AddCommand(
+		GetCmdQueryPort(),
+	)
+
+	return queryCmd
+}

modules/core/05-port/client/cli/query.go

@@ -0,0 +1,54 @@
+package cli
+
+import (
+	"fmt"
+
+	"github.com/spf13/cobra"
+
+	"github.com/cosmos/cosmos-sdk/client"
+	"github.com/cosmos/cosmos-sdk/client/flags"
+	"github.com/cosmos/cosmos-sdk/version"
+
+	channeltypes "github.com/cosmos/ibc-go/modules/core/04-channel/types"
+	"github.com/cosmos/ibc-go/modules/core/05-port/types"
+	host "github.com/cosmos/ibc-go/modules/core/24-host"
+)
+
+// GetCmdQueryPorts defines the command to query a port
+func GetCmdQueryPort() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:     "port [port-id] [counterparty-port-id] [counterparty-channel-id] [counterparty-version]",
+		Short:   "Query an IBC port",
+		Long:    "Query an IBC port by providing it's port ID and associated counterparty port and channel identifiers",
+		Example: fmt.Sprintf("%s query %s %s port", version.AppName, host.ModuleName, types.SubModuleName),
+		Args:    cobra.ExactArgs(4),
+		RunE: func(cmd *cobra.Command, args []string) error {
+			clientCtx, err := client.GetClientQueryContext(cmd)
+			if err != nil {
+				return err
+			}
+
+			queryClient := types.NewQueryClient(clientCtx)
+
+			req := &types.QueryPortRequest{
+				PortId: args[0],
+				Counterparty: &channeltypes.Counterparty{
+					PortId:    args[1],
+					ChannelId: args[2],
+				},
+				CounterpartyVersion: args[3],
+			}
+
+			portRes, err := queryClient.Port(cmd.Context(), req)
+			if err != nil {
+				return err
+			}
+
+			return clientCtx.PrintProto(portRes)
+		},
+	}
+
+	flags.AddQueryFlagsToCmd(cmd)
+
+	return cmd
+}

modules/core/05-port/keeper/grpc_query.go

@@ -0,0 +1,52 @@
+package keeper
+
+import (
+	"context"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
+
+	"github.com/cosmos/ibc-go/modules/core/05-port/types"
+	host "github.com/cosmos/ibc-go/modules/core/24-host"
+)
+
+var _ types.QueryServer = (*Keeper)(nil)
+
+// Port implements the Query/Port gRPC method
+func (q Keeper) Port(c context.Context, req *types.QueryPortRequest) (*types.QueryPortResponse, error) {
+	if req == nil {
+		return nil, status.Error(codes.InvalidArgument, "empty request")
+	}
+
+	if err := validategRPCRequest(req.PortId); err != nil {
+		return nil, err
+	}
+
+	ctx := sdk.UnwrapSDKContext(c)
+	module, _, err := q.LookupModuleByPort(ctx, req.PortId)
+	if err != nil {
+		return nil, status.Errorf(codes.NotFound, sdkerrors.Wrap(err, "could not retrieve module from port-id").Error())
+	}
+
+	ibcModule, found := q.Router.GetRoute(module)
+	if !found {
+		return nil, status.Errorf(codes.NotFound, sdkerrors.Wrapf(types.ErrInvalidRoute, "route not found to module: %s", module).Error())
+	}
+
+	version, err := ibcModule.NegotiateAppVersion(ctx, req.PortId, *req.Counterparty, req.CounterpartyVersion)
+	if err != nil {
+		return nil, status.Errorf(codes.InvalidArgument, sdkerrors.Wrap(err, "version negotation failed").Error())
+	}
+
+	return types.NewQueryPortResponse(req.PortId, version), nil
+}
+
+func validategRPCRequest(portID string) error {
+	if err := host.PortIdentifierValidator(portID); err != nil {
+		return status.Error(codes.InvalidArgument, err.Error())
+	}
+
+	return nil
+}

modules/core/05-port/keeper/keeper.go

@@ -14,6 +14,8 @@ import (
 
 // Keeper defines the IBC connection keeper
 type Keeper struct {
+	Router *types.Router
+
 	scopedKeeper capabilitykeeper.ScopedKeeper
 }
 

modules/core/05-port/module.go

@@ -0,0 +1,24 @@
+package port
+
+import (
+	"github.com/gogo/protobuf/grpc"
+	"github.com/spf13/cobra"
+
+	"github.com/cosmos/ibc-go/modules/core/05-port/types"
+	"github.com/cosmos/ibc-go/modules/core/client/cli"
+)
+
+// Name returns the IBC port ICS name.
+func Name() string {
+	return types.SubModuleName
+}
+
+// GetQueryCmd returns the root query command for IBC ports.
+func GetQueryCmd() *cobra.Command {
+	return cli.GetQueryCmd()
+}
+
+// RegisterQueryService registers the gRPC query service for IBC ports.
+func RegisterQueryService(server grpc.Server, queryServer types.QueryServer) {
+	types.RegisterQueryServer(server, queryServer)
+}

modules/core/05-port/types/errors.go

@@ -6,8 +6,9 @@ import (
 
 // IBC port sentinel errors
 var (
-	ErrPortExists   = sdkerrors.Register(SubModuleName, 2, "port is already binded")
-	ErrPortNotFound = sdkerrors.Register(SubModuleName, 3, "port not found")
-	ErrInvalidPort  = sdkerrors.Register(SubModuleName, 4, "invalid port")
-	ErrInvalidRoute = sdkerrors.Register(SubModuleName, 5, "route not found")
+	ErrPortExists     = sdkerrors.Register(SubModuleName, 2, "port is already binded")
+	ErrPortNotFound   = sdkerrors.Register(SubModuleName, 3, "port not found")
+	ErrInvalidPort    = sdkerrors.Register(SubModuleName, 4, "invalid port")
+	ErrInvalidRoute   = sdkerrors.Register(SubModuleName, 5, "route not found")
+	ErrInvalidVersion = sdkerrors.Register(SubModuleName, 6, "invalid port version")
 )

modules/core/05-port/types/module.go

@@ -82,4 +82,11 @@ type IBCModule interface {
 		packet channeltypes.Packet,
 		relayer sdk.AccAddress,
 	) error
+
+	NegotiateAppVersion(
+		ctx sdk.Context,
+		portID string,
+		counterparty channeltypes.Counterparty,
+		counterpartyVersion string,
+	) (version string, err error)
 }

modules/core/05-port/types/query.go

@@ -0,0 +1,9 @@
+package types
+
+// NewQueryPortResponse creates a new QueryPortResponse instance
+func NewQueryPortResponse(portID, version string) *QueryPortResponse {
+	return &QueryPortResponse{
+		PortId:  portID,
+		Version: version,
+	}
+}