deps: sdk v0.50-alpha

.dockerignore

@@ -0,0 +1,8 @@
+.github
+.contrib
+docs/
+proto/
+scripts/
+testing/
+Dockefile
+**/*.md

.github/workflows/e2e-fork.yml

@@ -26,7 +26,8 @@ jobs:
         env:
           TEST_EXCLUSIONS: 'TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite'
 
-  e2e:
+  # e2e-fork runs the e2e tests directly by using a matrix strategy.
+  e2e-fork:
     env:
       CHAIN_A_TAG: latest
       CHAIN_B_TAG: latest

.github/workflows/e2e.yaml

@@ -1,5 +1,14 @@
+# The Tests / E2E workflow is used to run end-to-end tests on pull requests originating
+# from the ibc-go repository. The workflow is triggered on a PR opening, when new commits
+# are pushed to the PR, or when the PR is marked ready for review.
+#
+# A scheduled job is also set up to run every night. This job is used to run e2e tests
+# using the hermes relayer.
 name: Tests / E2E
 on:
+  # This schedule is used solely for hermes and is set to run every night.
+  schedule:
+    - cron: "0 0 * * *"
   workflow_dispatch:
   pull_request:
     types:
@@ -37,7 +46,16 @@ jobs:
             echo "Using tag $tag"
             echo "simd-tag=$tag" >> $GITHUB_OUTPUT
           fi
-
+      # get-relayer will return either hermes or rly depending on whether the workflow was triggered
+      # by a scheduled run or not.
+      - id: get-relayer
+        run: |
+          if [ "${{ github.event_name }}" == "schedule" ]
+          then
+            echo "relayer=hermes" >> $GITHUB_OUTPUT
+          else
+            echo "relayer=rly" >> $GITHUB_OUTPUT
+          fi
   # build-e2e ensures that all test code compiles.
   build-e2e:
     if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
@@ -53,10 +71,12 @@ jobs:
           find ./tests -type d | while IFS= read -r dir
           do
               if ls "${dir}"/*.go >/dev/null 2>&1; then
-                  GOARCH=arm64 go test -c "$dir" 2>/dev/null
+                  GOARCH=arm64 go test -c "$dir"
               fi
           done
 
+  # e2e generates the e2e tests for the non-forked PRs. It does so by using the
+  # e2e-test-workflow-call.yml each test runs the jobs defined in that file.
   e2e:
     # we will be running this job if the PR has not yet been marked for review, and we push additional changes.
     # we skip the job in this case.
@@ -80,3 +100,4 @@ jobs:
       chain-binary: 'simd'
       # on regular PRs we won't run interchain account or upgrade tests.
       test-exclusions: 'TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite'
+      relayer-tag: "${{ needs.determine-image-tag.outputs.relayer }}"

.github/workflows/golangci.yml

@@ -22,5 +22,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3.6.0
         with:
-          version: v1.52.0
+          version: v1.53.1
           args: --timeout 5m

.github/workflows/test.yml

@@ -57,7 +57,7 @@ jobs:
           find ./tests -type d | while IFS= read -r dir
           do
               if ls "${dir}"/*.go >/dev/null 2>&1; then
-                  GOARCH=arm64 go test -c "$dir" 2>/dev/null
+                  GOARCH=arm64 go test -c "$dir"
               fi
           done
 

.gitignore

@@ -58,4 +58,3 @@ dependency-graph.png
 
 # Go
 go.work
-go.work.sum

.golangci.yml

@@ -6,7 +6,6 @@ run:
 linters:
   disable-all: true
   enable:
-    - depguard
     - dogsled
     - exportloopref
     - errcheck
@@ -19,7 +18,10 @@ linters:
     - ineffassign
     - misspell
     - nakedret
+    - paralleltest
     - staticcheck
+    - tparallel
+    - thelper
     - stylecheck
     - revive
     - typecheck

cmd/build_test_matrix/main_test.go

@@ -17,13 +17,16 @@ const (
 )
 
 func TestGetGithubActionMatrixForTests(t *testing.T) {
+	t.Parallel()
 	t.Run("empty dir does not fail", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		_, err := getGithubActionMatrixForTests(testingDir, "", "", nil)
 		assert.NoError(t, err)
 	})
 
 	t.Run("only test functions are picked up", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		createFileWithTestSuiteAndTests(t, "FeeMiddlewareTestSuite", "TestA", "TestB", testingDir, goTestFileNameOne)
 
@@ -46,6 +49,7 @@ func TestGetGithubActionMatrixForTests(t *testing.T) {
 	})
 
 	t.Run("all files are picked up", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		createFileWithTestSuiteAndTests(t, "FeeMiddlewareTestSuite", "TestA", "TestB", testingDir, goTestFileNameOne)
 		createFileWithTestSuiteAndTests(t, "TransferTestSuite", "TestC", "TestD", testingDir, goTestFileNameTwo)
@@ -78,6 +82,7 @@ func TestGetGithubActionMatrixForTests(t *testing.T) {
 	})
 
 	t.Run("single test can be specified", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		createFileWithTestSuiteAndTests(t, "FeeMiddlewareTestSuite", "TestA", "TestB", testingDir, goTestFileNameOne)
 		createFileWithTestSuiteAndTests(t, "TransferTestSuite", "TestC", "TestD", testingDir, goTestFileNameTwo)
@@ -98,6 +103,7 @@ func TestGetGithubActionMatrixForTests(t *testing.T) {
 	})
 
 	t.Run("error if single test doesn't exist", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		createFileWithTestSuiteAndTests(t, "FeeMiddlewareTestSuite", "TestA", "TestB", testingDir, goTestFileNameOne)
 
@@ -106,6 +112,7 @@ func TestGetGithubActionMatrixForTests(t *testing.T) {
 	})
 
 	t.Run("non test files are not picked up", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		createFileWithTestSuiteAndTests(t, "FeeMiddlewareTestSuite", "TestA", "TestB", testingDir, nonTestFile)
 
@@ -115,6 +122,7 @@ func TestGetGithubActionMatrixForTests(t *testing.T) {
 	})
 
 	t.Run("fails when there are multiple suite runs", func(t *testing.T) {
+		t.Parallel()
 		testingDir := t.TempDir()
 		createFileWithTestSuiteAndTests(t, "FeeMiddlewareTestSuite", "TestA", "TestB", testingDir, nonTestFile)
 
@@ -139,6 +147,7 @@ type FeeMiddlewareTestSuite struct {}
 }
 
 func assertGithubActionTestMatricesEqual(t *testing.T, expected, actual GithubActionTestMatrix) {
+	t.Helper()
 	// sort by both suite and test as the order of the end result does not matter as
 	// all tests will be run.
 	sort.SliceStable(expected.Include, func(i, j int) bool {
@@ -183,6 +192,7 @@ func helper() {}
 }
 
 func createFileWithTestSuiteAndTests(t *testing.T, suiteName, fn1Name, fn2Name, dir, filename string) {
+	t.Helper()
 	goFileContents := goTestFileContents(suiteName, fn1Name, fn2Name)
 	err := os.WriteFile(path.Join(dir, filename), []byte(goFileContents), os.FileMode(0o777))
 	assert.NoError(t, err)

docs/ibc/integration.md

@@ -164,7 +164,7 @@ In order to use IBC, we need to add the new modules to the module `Manager` and
 func NewApp(...args) *App {
   // .. continuation from above
 
-  app.mm = module.NewManager(
+  app.ModuleManager = module.NewManager(
     // other modules
     // ...
     capability.NewAppModule(appCodec, *app.CapabilityKeeper),
@@ -199,7 +199,7 @@ func NewApp(...args) *App {
   // .. continuation from above
 
   // add staking and ibc modules to BeginBlockers
-  app.mm.SetOrderBeginBlockers(
+  app.ModuleManager.SetOrderBeginBlockers(
     // other modules ...
     stakingtypes.ModuleName, ibcexported.ModuleName,
   )
@@ -209,7 +209,7 @@ func NewApp(...args) *App {
   // NOTE: Capability module must occur first so that it can initialize any capabilities
   // so that other modules that want to create or claim capabilities afterwards in InitChain
   // can do so safely.
-  app.mm.SetOrderInitGenesis(
+  app.ModuleManager.SetOrderInitGenesis(
     capabilitytypes.ModuleName,
     // other modules ...
     ibcexported.ModuleName, ibctransfertypes.ModuleName,

docs/migrations/sdk-to-v1.md

@@ -60,7 +60,7 @@ app.UpgradeKeeper.SetUpgradeHandler("my-upgrade-proposal",
       "ibc":          1,
       ... 
     }   
-    return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+    return app.ModuleManager.RunMigrations(ctx, app.configurator, fromVM)
   })      
 
 ```

docs/migrations/support-denoms-with-slashes.md

@@ -32,7 +32,7 @@ The transfer module will now support slashes in base denoms, so we must iterate
 app.UpgradeKeeper.SetUpgradeHandler("MigrateTraces",
   func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
     // transfer module consensus version has been bumped to 2
-    return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+    return app.ModuleManager.RunMigrations(ctx, app.configurator, fromVM)
   })
 ```
 

docs/migrations/v2-to-v3.md

@@ -56,7 +56,7 @@ app.UpgradeKeeper.SetUpgradeHandler("v3",
 
     ...
 
-    return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+    return app.ModuleManager.RunMigrations(ctx, app.configurator, fromVM)
   })
 ```
 

docs/migrations/v3-to-v4.md

@@ -51,7 +51,7 @@ If the chain will migrate to supporting base denoms with slashes, it must set th
 app.UpgradeKeeper.SetUpgradeHandler("MigrateTraces",
   func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
     // transfer module consensus version has been bumped to 2
-    return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+    return app.ModuleManager.RunMigrations(ctx, app.configurator, fromVM)
   })
 ```
 

docs/migrations/v4-to-v5.md

@@ -42,7 +42,7 @@ The `AnteDecorator` was actually renamed twice, but in [this PR](https://github.
 
 ### Core
 
-The `key` parameter of the `NewKeeper` function in `modules/core/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
+The `key` parameter of the `NewKeeper` function in `modules/core/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`):
 
 ```diff
 func NewKeeper(
@@ -60,7 +60,7 @@ The `RegisterRESTRoutes` function in `modules/core` has been removed.
 
 ### ICS03 - Connection
 
-The `key` parameter of the `NewKeeper` function in `modules/core/03-connection/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
+The `key` parameter of the `NewKeeper` function in `modules/core/03-connection/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`):
 
 ```diff
 func NewKeeper(
@@ -85,7 +85,7 @@ The function `NewPacketId` in `modules/core/04-channel/types` has been renamed t
 ) PacketId 
 ```
 
-The `key` parameter of the `NewKeeper` function in `modules/core/04-channel/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
+The `key` parameter of the `NewKeeper` function in `modules/core/04-channel/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`):
 
 ```diff
 func NewKeeper(
@@ -101,7 +101,7 @@ func NewKeeper(
 
 ### ICS20 - Transfer
 
-The `key` parameter of the `NewKeeper` function in `modules/apps/transfer/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
+The `key` parameter of the `NewKeeper` function in `modules/apps/transfer/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`):
 
 ```diff
 func NewKeeper(
@@ -137,7 +137,7 @@ The `key` and `msgRouter` parameters of the `NewKeeper` functions in
 - `modules/apps/27-interchain-accounts/controller/keeper`
 - and `modules/apps/27-interchain-accounts/host/keeper`
 
-have changed type. The `key` parameter is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`), and the `msgRouter` parameter is now of type `*icatypes.MessageRouter` (where `icatypes` is an import alias for `"github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/types"`):
+have changed type. The `key` parameter is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`), and the `msgRouter` parameter is now of type `*icatypes.MessageRouter` (where `icatypes` is an import alias for `"github.com/cosmos/ibc-go/v5/modules/apps/27-interchain-accounts/types"`):
 
 ```diff
 // NewKeeper creates a new interchain accounts controller Keeper instance
@@ -283,7 +283,7 @@ See [ADR-03](../architecture/adr-003-ics27-acknowledgement.md/#next-major-versio
 
 ### ICS29 - Fee Middleware
 
-The `key` parameter of the `NewKeeper` function in `modules/apps/29-fee` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
+The `key` parameter of the `NewKeeper` function in `modules/apps/29-fee` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`):
 
 ```diff
 func NewKeeper(
@@ -337,7 +337,7 @@ type StakingKeeper interface {
 }
 ```
 
-- The return type of the function `LastCommitID` has changed to `storetypes.CommitID` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`).
+- The return type of the function `LastCommitID` has changed to `storetypes.CommitID` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`).
 
 See the following `git diff` for more details:
 
@@ -420,7 +420,7 @@ The `RegisterRESTRoutes` function in `testing/mock` has been removed.
 
 ### ICS02 - Client
 
-The `key` parameter of the `NewKeeper` function in `modules/core/02-client/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
+The `key` parameter of the `NewKeeper` function in `modules/core/02-client/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"cosmossdk.io/store/types"`):
 
 ```diff
 func NewKeeper(

docs/migrations/v5-to-v6.md

@@ -35,11 +35,11 @@ package v6
 
 import (
   "github.com/cosmos/cosmos-sdk/codec"
-  storetypes "github.com/cosmos/cosmos-sdk/store/types"
+  storetypes "cosmossdk.io/store/types"
   sdk "github.com/cosmos/cosmos-sdk/types"
   "github.com/cosmos/cosmos-sdk/types/module"
   capabilitykeeper "github.com/cosmos/cosmos-sdk/x/capability/keeper"
-  upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
+  upgradetypes "cosmossdk.io/x/upgrade/types"
 
   v6 "github.com/cosmos/ibc-go/v6/modules/apps/27-interchain-accounts/controller/migrations/v6"
 )
@@ -72,7 +72,7 @@ func CreateUpgradeHandler(
 app.UpgradeKeeper.SetUpgradeHandler(
   v6.UpgradeName,
   v6.CreateUpgradeHandler(
-    app.mm, 
+    app.ModuleManager, 
     app.configurator, 
     app.appCodec, 
     app.keys[capabilitytypes.ModuleName], 

docs/migrations/v6-to-v7.md

@@ -36,7 +36,7 @@ app.UpgradeKeeper.SetUpgradeHandler(
       return nil, err
     }
 
-    return app.mm.RunMigrations(ctx, app.configurator, fromVM)
+    return app.ModuleManager.RunMigrations(ctx, app.configurator, fromVM)
   },
 )
 ```

e2e/tests/core/02-client/client_test.go

@@ -15,12 +15,12 @@ import (
 	tmprotoversion "github.com/cometbft/cometbft/proto/tendermint/version"
 	tmtypes "github.com/cometbft/cometbft/types"
 	tmversion "github.com/cometbft/cometbft/version"
-	"github.com/cosmos/cosmos-sdk/client/grpc/tmservice"
 	"github.com/strangelove-ventures/interchaintest/v7/chain/cosmos"
 	"github.com/strangelove-ventures/interchaintest/v7/ibc"
 	test "github.com/strangelove-ventures/interchaintest/v7/testutil"
 	"github.com/stretchr/testify/suite"
 
+	"github.com/cosmos/cosmos-sdk/client/grpc/ccmtservice"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
 
 	govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
@@ -204,7 +204,7 @@ func (s *ClientTestSuite) TestClient_Update_Misbehaviour() {
 	})
 
 	t.Run("create validator set", func(t *testing.T) {
-		var validators []*tmservice.Validator
+		var validators []*ccmtservice.Validator
 
 		t.Run("fetch block header at latest client state height", func(t *testing.T) {
 			header, err = s.GetBlockHeaderByHeight(ctx, chainB, latestHeight.GetRevisionHeight())
@@ -367,7 +367,7 @@ func createMaliciousTMHeader(chainID string, blockHeight int64, trustedHeight cl
 	blockID := ibctesting.MakeBlockID(hhash, 3, tmhash.Sum([]byte(invalidHashValue)))
 	voteSet := tmtypes.NewVoteSet(chainID, blockHeight, 1, tmproto.PrecommitType, tmValSet)
 
-	commit, err := tmtypes.MakeCommit(blockID, blockHeight, 1, voteSet, signers, timestamp)
+	commit, err := test.MakeCommit(blockID, blockHeight, 1, voteSet, signers, timestamp)
 	if err != nil {
 		return nil, err
 	}

e2e/tests/upgrades/upgrade_test.go

@@ -7,9 +7,9 @@ import (
 	"time"
 
 	sdkmath "cosmossdk.io/math"
+	upgradetypes "cosmossdk.io/x/upgrade/types"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
-	upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
 	"github.com/cosmos/gogoproto/proto"
 	intertxtypes "github.com/cosmos/interchain-accounts/x/inter-tx/types"
 	interchaintest "github.com/strangelove-ventures/interchaintest/v7"