test: adding msg_server test for 29-fee #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: adding MsgServer for RegisterCounterPartyAddress & EscrowPacketFree * test: adding test for ValidateBasic * fix: removing validate basic check * fix: removing empty file * Update modules/apps/29-fee/keeper/msg_server.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update modules/apps/29-fee/types/msgs.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update modules/apps/29-fee/types/keys.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update modules/apps/29-fee/keeper/keeper.go Co-authored-by: Aditya <adityasripal@gmail.com> * fix: fixing typos, variable names, comments * fix: updating import comments * test: adding test for KeyRelayerAddress * update: comments & key_test * Update modules/apps/29-fee/keeper/msg_server.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * fix: error message * docs: updating RegisterCounterpartyAddress fn description Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com>
seantking
commented
Sep 10, 2021
seantking
changed the title
Codecov Report
@@ Coverage Diff @@
## aditya/handshake #391 +/- ##
=================================================
Coverage 78.33% 78.33%
=================================================
Files 121 124 +3
Lines 9781 9851 +70
=================================================
+ Hits 7662 7717 +55
- Misses 1734 1747 +13
- Partials 385 387 +2
|
colin-axner
approved these changes
Sep 13, 2021
faddat
pushed a commit
to notional-labs/ibc-go
that referenced
this pull request
Mar 1, 2022
* fix client match bug * add sanity check * fix build * apply @AdityaSripal suggestion * add comment for sanity check * fix wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding tests for
msg_server.In order to write the
msg_servertests I needed to merge the latest changes fromics29-fee-middlewarefeature branch into the handshake PR @AdityaSripal is working on as I needed some of the changes on @AdityaSripal branch (module.go wiring etc).This branch is merging into
aditya/handshakenotics29-fee-middleware. Note that most of the changes are from the latest code on the feature branch.closes: #258
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes