sdk 50 against main #3952
sdk 50 against main #3952
Conversation
This reverts commit 4580f76.
This reverts commit 69933c3.
…tation of code similar to testing/chain.go
|
|
|
Hey guys, I am currently doing the merge for this and I must say that I agree with Marko, it is much better to target main. Currently the merge is just a lot of playing catch-up. I think that it'll definitely be easier for all parties to work on this if it targets main rather than a feature branch that lags main. Doing things this way knocked many files out of the diff. |
|
@crodriguezvega could you please let us know if you are OK with targeting main instead of a feature branch by closing either this PR or #3883 ? thanks! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -332,54 +351,71 @@ | |||
|
|
|||
| // SDK module keepers | |||
|
|
|||
| app.AccountKeeper = authkeeper.NewAccountKeeper(appCodec, keys[authtypes.StoreKey], authtypes.ProtoBaseAccount, maccPerms, sdk.GetConfig().GetBech32AccountAddrPrefix(), authtypes.NewModuleAddress(govtypes.ModuleName).String()) | |||
| // add keepers | |||
| app.AccountKeeper = authkeeper.NewAccountKeeper(appCodec, runtime.NewKVStoreService(keys[authtypes.StoreKey]), authtypes.ProtoBaseAccount, maccPerms, sdk.Bech32MainPrefix, authtypes.NewModuleAddress(govtypes.ModuleName).String()) | |||
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
Thank you, @faddat. I replied in the other PR. |
|
I'm going ot close this one and keep the branch for reference later. |
This PR is a test run of making changes directly to main instead of a feature branch, as was originally done for this
PR.