-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: use storetypes instead of sdk types #4009
Conversation
This reverts commit fc42343.
was definitely supposed to be in the 50 branch :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4009 +/- ##
=======================================
Coverage 78.88% 78.88%
=======================================
Files 187 187
Lines 12983 12983
=======================================
Hits 10241 10241
Misses 2313 2313
Partials 429 429
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending CI, lgtm! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
woah, awesome this could be pulled out, thanks @faddat! Also thanks @damiannolan @chatton @DimitrisJim for the ultra fast reviews! ⚡ Y'all are the best! |
Description
This PR changes the sdk.KVStore to storetypes.KVStore
Related PRs:
#3883
Commit Message / Changelog Entry