Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: use storetypes instead of sdk types #4009

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 5, 2023

Description

This PR changes the sdk.KVStore to storetypes.KVStore

Related PRs:

#3883

Commit Message / Changelog Entry

imp: use storetypes instead of sdk types

modules/core/module.go Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor Author

faddat commented Jul 5, 2023

was definitely supposed to be in the 50 branch :)

@codecov-commenter
Copy link

Codecov Report

Merging #4009 (d435b68) into main (315680c) will not change coverage.
The diff coverage is 92.22%.

❗ Current head d435b68 differs from pull request most recent head c82599f. Consider uploading reports for the commit c82599f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4009   +/-   ##
=======================================
  Coverage   78.88%   78.88%           
=======================================
  Files         187      187           
  Lines       12983    12983           
=======================================
  Hits        10241    10241           
  Misses       2313     2313           
  Partials      429      429           
Impacted Files Coverage Δ
...odules/core/02-client/migrations/v7/solomachine.go 18.30% <0.00%> (ø)
...es/light-clients/06-solomachine/proposal_handle.go 69.56% <ø> (ø)
...les/light-clients/07-tendermint/proposal_handle.go 79.66% <ø> (ø)
modules/light-clients/07-tendermint/upgrade.go 73.86% <ø> (ø)
...dules/light-clients/06-solomachine/client_state.go 88.28% <75.00%> (ø)
modules/light-clients/09-localhost/client_state.go 91.66% <88.88%> (ø)
...27-interchain-accounts/controller/keeper/keeper.go 90.62% <100.00%> (ø)
...in-accounts/controller/migrations/v6/migrations.go 92.30% <100.00%> (ø)
.../apps/27-interchain-accounts/host/keeper/keeper.go 85.38% <100.00%> (ø)
modules/apps/29-fee/keeper/keeper.go 92.30% <100.00%> (ø)
... and 13 more

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending CI, lgtm! 🙏

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damiannolan damiannolan merged commit 3b4e3d3 into cosmos:main Jul 5, 2023
@colin-axner
Copy link
Contributor

colin-axner commented Jul 5, 2023

woah, awesome this could be pulled out, thanks @faddat! Also thanks @damiannolan @chatton @DimitrisJim for the ultra fast reviews! ⚡ Y'all are the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants