-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp!: allow failure expectations when using chain.SendMsgs #4018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks like a good idea to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea, sgtm!
Just a note this will be reconfigured in the update to Eden, but the same concept is applied. If the tx returns a non-zero error code, it will be returned as an error to the SendMsgs caller |
Description
Allow failure expectations from function calls which use
chain.SendMsgs()
e.g. I want to be able to call
endpoint.ChanUpgradeInit()
and expect an error is returnedtesting.TB
andexpPass
args fromSignAndDeliver
and allows the caller to determine whether or not the expectation is success or failure.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.