-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: make separate go.mod for 08-wasm #4026
imp: make separate go.mod for 08-wasm #4026
Conversation
The error here I've seen it happening already for some time, but I haven't figure out what the problem is, because the type is correctly imported... |
I think wasmvm ain't playing nicely with arm, the relevant code is not generated in this case. It builds just fine locally (amd). Trying to think of a way to get this to be skipped when dealing with the wasm client. |
ahhh, this makes sense! i was really confused why it was working for me locally as well. |
can we try this here to see if we can compile? There is no e2e tests using the 08-wasm features atm right? - go test -c "$dir"
+ CGO_ENABLED=0 go test -c "$dir" Has anyone managed to run our simd docker image and use a wasm client yet? I suspect the build setup in the Dockerfile will require some configuration judging by the wasmvm readme. Does running wasm clients work out of the box on macos? I imagine it requires some rust libraries etc for simd to instantiate the vm? I'm curious to see if the above will work, I think it might be trying to cross compile with cgo as I think(?) edit: Oh I just saw #4029, maybe CI needs to be re-run after a merge |
This should fix it for the
The current error when building the simd image with the dockerfile stems from the fact that we add the modules after trying to download dependencies (since we pin 08-wasm to a local directory, it fails since we add the code in a later step). After reorganizing, the build succeeds but we do indeed fail again since we don't have shared library for libwasmvm. I think we could take inspiration from here but I haven't attempted it. yet. |
All checks have passed, @DimitrisJim and @charleenfei! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to finally see the green here 💚
Description
closes: #3975
Commit Message / Changelog Entry
imp: make separate go.mod for 08-wasm
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.