Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] deps: upgrade capability to sdk v0.50 #4057

Closed
wants to merge 11 commits into from

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jul 10, 2023

Description

This PR removes the dependency of ibc-go simapp from the capability module and upgrades it to sdk v0.50

closes: #4055


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@@ -26,7 +26,6 @@ import (
)

var (
_ module.BeginBlockAppModule = (*AppModule)(nil)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tac0turtle I see there's now a HasABCIEndblock interface, is there a similar interface for BeginBlock now or is it inferred somewhere else?

Copy link
Member Author

@damiannolan damiannolan Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is for legacy? and now core/appmodule is the std with HasBeginBlocker moving forward?

Can't make an interface assertion here yet as arg in the new interface is a regular go ctx

@faddat
Copy link
Contributor

faddat commented Jul 11, 2023

ohhhh this is a WONDEFUL change.

Love how there's no more dependency!

@faddat faddat mentioned this pull request Jul 11, 2023
9 tasks
@damiannolan
Copy link
Member Author

I think this PR can be closed and superseded by #4068. After some thought and a few hours of working on this I felt there was more value in refactoring the capability tests to not depend on any simapp at all.

Some of the tests in x/capability have been chopped and changed by many devs pushing code to the sdk over the last couple of years and as a result I think it wasn't clear what the tests were doing. I think few people had a good understanding of what TestInitializeMemStore was doing, mocking a statesync scenario, so I have tried to clean that up and add in-line code comments to make things more clear.

@damiannolan damiannolan deleted the damian/4055-remove-dep-capability branch December 8, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on ibc-go from capability module
2 participants