Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual setting of flush status in ChanUpgradeOpen #4064

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Remove manual setting of flush status in ChanUpgradeOpen #4064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de76632
Remove manual setting of flush status in ChanUpgradeOpen.
DimitrisJim Jul 11, 2023
1544a02
Merge branch '04-channel-upgrades' into jim/remove-manual-set-of-flus…
DimitrisJim Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions modules/core/04-channel/keeper/upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,15 +734,6 @@ func (suite *KeeperTestSuite) TestChanUpgradeOpen() {
err = path.EndpointB.ChanUpgradeAck()
suite.Require().NoError(err)

// TODO: Remove setting of FLUSHCOMPLETE once #3928 is completed
channelB := path.EndpointB.GetChannel()
channelB.FlushStatus = types.FLUSHCOMPLETE
path.EndpointB.SetChannel(channelB)

channelA := path.EndpointA.GetChannel()
channelA.FlushStatus = types.FLUSHCOMPLETE
path.EndpointA.SetChannel(channelA)

suite.coordinator.CommitBlock(suite.chainA, suite.chainB)
suite.Require().NoError(path.EndpointA.UpdateClient())

Expand Down