Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: adding MetadataFromVersion to 29-fee pkg types #4100

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Jul 17, 2023

Description

Cherry-picked b19b53b and fb6a42a from #4019

Opened: #4101


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review July 17, 2023 10:36
@damiannolan damiannolan changed the title Damian/fee metadata from version imp: adding MetadataFromVersion to 29-fee pkg types Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #4100 (837b251) into main (5c17048) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4100      +/-   ##
==========================================
+ Coverage   78.88%   78.89%   +0.01%     
==========================================
  Files         187      188       +1     
  Lines       12983    12990       +7     
==========================================
+ Hits        10241    10248       +7     
  Misses       2313     2313              
  Partials      429      429              
Impacted Files Coverage Δ
modules/apps/29-fee/types/metadata.go 100.00% <100.00%> (ø)

@damiannolan damiannolan enabled auto-merge (squash) July 19, 2023 08:34
@damiannolan damiannolan merged commit 31b3c60 into main Jul 20, 2023
@damiannolan damiannolan deleted the damian/fee-metadata-from-version branch July 20, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants