Move check for upgraded client state height to 02-client layer.

[DimitrisJim]

Description

closes: #4212, removing this check in the 08-wasm module is additionally required. (Removed check in 08-wasm module)

Commit Message / Changelog Entry

chore: move check for upgraded client state height in 02-client layer.

see the guidelines for commit messages. (view raw markdown for examples)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[DimitrisJim]

note that I added a test case here but additionally left the others present in 07-tendermint. (which also need tweaking since they fall victim to the whole not checking error returned and thereby not always checking what they are supposed to)

[codecov-commenter]

Codecov Report

Merging #4368 (5620977) into main (3b1e4e2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4368   +/-   ##
=======================================
  Coverage   79.57%   79.57%           
=======================================
  Files         189      189           
  Lines       13261    13266    +5     
=======================================
+ Hits        10552    10557    +5     
  Misses       2288     2288           
  Partials      421      421           

Files	Coverage Δ
modules/core/02-client/keeper/client.go	94.30% <100.00%> (+0.22%)	⬆️
modules/light-clients/07-tendermint/upgrade.go	73.56% <100.00%> (-0.31%)	⬇️

[crodriguezvega]

Thanks for picking this up, @DimitrisJim. Since the check needs to be removed in both 07-tendermint and 08-wasm, I think it would be best to wait until we merge 08-wasm to main and then we can fully address the whole issue in a single PR. What do you think?

[DimitrisJim]

I think it would be best to wait until we merge 08-wasm to main and then we can fully address the whole issue in a single PR. What do you think?

sounds perfectly fine to me, we can leave as is and I'll just rebase when the time is right

[crodriguezvega]

Looks fine to me. Happy that we can finally merge this one! :)

[chatton]

LGTM thanks @DimitrisJim

[colin-axner]

LGTM, the 02-client tests should really be refactored some day, seems like some rearrangement could remove a lot of code cov