Allow verification of channels on TimeoutonClose and ChanCloseConfirm #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
changed the title
DimitrisJim
force-pushed
the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
2 times, most recently
from
d76910b to
bbb4310
Compare
DimitrisJim
force-pushed
the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
3 times, most recently
from
99495be to
528caac
Compare
DimitrisJim
force-pushed
the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
from
528caac to
bd42f13
Compare
DimitrisJim
force-pushed
the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
2 times, most recently
from
0e4fdb1 to
adb49b9
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
chatton
as code owners
|
in most tests the default value of 0 is used considering channel being tested is not performing an upgrade. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 04-channel-upgrades #4388 +/- ##
=======================================================
+ Coverage 80.39% 80.40% +0.01%
=======================================================
Files 197 197
Lines 14985 14996 +11
=======================================================
+ Hits 12047 12058 +11
Misses 2474 2474
Partials 464 464
|
DimitrisJim
force-pushed
the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
from
adb49b9 to
b839b23
Compare
colin-axner
approved these changes
Dec 13, 2023
DimitrisJim
force-pushed
the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
from
b839b23 to
d8f1ee0
Compare
…ty upgrade sequence.
colin-axner
approved these changes
Dec 13, 2023
damiannolan
approved these changes
Dec 14, 2023
…-verification-during-upgrade
DimitrisJim
deleted the
jim/4081-timeoutonclose-fails-verification-during-upgrade
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4081
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.