Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed broken links from cosmos-sdk #4571

Merged
merged 1 commit into from
Sep 5, 2023
Merged

docs: fixed broken links from cosmos-sdk #4571

merged 1 commit into from
Sep 5, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Sep 5, 2023

Description

The SDK refactored their docs: cosmos/cosmos-sdk#17459

closes: #XXXX

Commit Message / Changelog Entry

docs: fixed broken links from cosmos-sdk

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@srdtrk srdtrk added the docs Improvements or additions to documentation label Sep 5, 2023
damiannolan
damiannolan approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @srdtrk!

@DimitrisJim DimitrisJim enabled auto-merge (squash) September 5, 2023 08:55
@DimitrisJim
Copy link
Contributor

enabling auto merge after job passed

charleenfei
charleenfei approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @srdtrk!

@DimitrisJim DimitrisJim merged commit c445fcc into main Sep 5, 2023
1 check passed
@DimitrisJim DimitrisJim deleted the serdar/sdk-docs-path-refactor branch September 5, 2023 08:57
@chatton
Copy link
Contributor

chatton commented Sep 5, 2023

❤️ thanks for the fix

mergify bot pushed a commit that referenced this pull request Sep 5, 2023
@srdtrk @mergify
docs: fixed broken links (#4571)
45086c9 
(cherry picked from commit c445fcc)

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
@mergify mergify bot mentioned this pull request Sep 5, 2023
Merged
srdtrk added a commit that referenced this pull request Sep 5, 2023
@mergify @srdtrk
docs: fixed broken links from cosmos-sdk (backport #4571) (#4573)
6c91777 
* docs: fixed broken links (#4571)

(cherry picked from commit c445fcc)

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md

* fix: fixed backport conflicts

---------

Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: srdtrk <srdtrk@hotmail.com>
charleenfei pushed a commit that referenced this pull request Sep 5, 2023
@srdtrk @charleenfei
docs: fixed broken links (#4571)
8a372bd
mergify bot pushed a commit that referenced this pull request Sep 7, 2023
@srdtrk @mergify
docs: fixed broken links (#4571)
e2d1327 
(cherry picked from commit c445fcc)

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md
@mergify mergify bot mentioned this pull request Sep 7, 2023
Merged
crodriguezvega pushed a commit that referenced this pull request Sep 7, 2023
@mergify @srdtrk @charleenfei
docs: fixed broken links from cosmos-sdk (backport #4571) (#4597)
dd8e98e 
* docs: fixed broken links (#4571)

(cherry picked from commit c445fcc)

# Conflicts:
#	.github/PULL_REQUEST_TEMPLATE.md

* fix merge conflict

---------

Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: Charly <charly@interchain.io>
damiannolan pushed a commit that referenced this pull request Sep 12, 2023
@srdtrk @damiannolan
docs: fixed broken links (#4571)
09d9966
crodriguezvega pushed a commit that referenced this pull request Sep 13, 2023
@mergify @damiannolan @srdtrk
chore: adding changelog to mod/capability (backport #4627) (#4636)
4ce845a 
* chore: adding changelog to mod/capability (#4627)

* chore: adding changelog to mod/capability

* Update modules/capability/CHANGELOG.md

Co-authored-by: Cian Hatton <cian@interchain.io>

---------

Co-authored-by: Cian Hatton <cian@interchain.io>
(cherry picked from commit 20b52cc)

* docs: fixed broken links (#4571)

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
colin-axner added a commit that referenced this pull request Sep 13, 2023
@colin-axner @DimitrisJim
@damiannolan @charleenfei @srdtrk @dependabot @stackman27 @chatton @julienrbrt @sontrinh16 @catShaark
refactor!: migrate to gov v1 via the additions of MsgRecoverClient …
26f7fe3 
…and `MsgIBCSoftwareUpgrade`. The legacy proposal types `ClientUpdateProposal` and `UpgradeClientProposal` have been removed. (#4620)

* Add proto message, implement sdk.Msg for Recover Client. (#4494)

* Add proto message for Recover client, implement sdk.Message interface.

* Update modules/core/02-client/types/msgs.go

Co-authored-by: Damian Nolan <damiannolan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Charly <charly@interchain.io>

* Remove gogoproto false for cmp, lint, move ibctesting address inline.

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Charly <charly@interchain.io>

* add protos, msgs, keeper handler to upgrade clients using v1 governance proposals (#4436)

* add protos and keeper function placeholder

* add keeper functions/tests, msgs and tests

* update to 0.47.5 release branch

* Move signer as last proto field. (#4510)

* msg server function and tests for MsgScheduleIBCClientUpgrade (#4442)

* Add 02-client implementation for Recover client. (#4499)

* Add 02-client implementation for Recover client.

* Partially address feedback.

* Docu RecoverClient, add label, re-use error.

* Add implementation for recover client on message server. (#4503)

* Add message server handler for recovering a client

* Don't assign to deprecated attrs, clean up unused fields.

* Further clean-up, remove declaration of unmutated vars.

* Add cmd for submitting a recover client prop. (#4522)

* Add cmd for submitting a recover client prop.

* Bump cosmossdk in e2e.

* Use govtypes.ModuleName, rename old govtypes to govv1beta1

* Update modules/core/02-client/client/cli/tx.go

Co-authored-by: Damian Nolan <damiannolan@gmail.com>

* Add auth flag.

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>

* rename command

* docs: fixed broken links (#4571)

* Add e2e test for recovering a client. (#4543)

Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>

* feat: add unpacket inerfaces message assertion (#4588)

* add cli for MsgIBCSoftwareUpgrade (#4558)

* docs: use MsgRecoverClient in docs (#4580)

* docs: recover client update

* Update docs/ibc/proposals.md

* Apply suggestions from code review

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

* refactor: remove legacy client update proposal (#4581)

* refactor: remove legacy client update proposal

* e2e: swap from ClientUpdateProposal e2e to RecoverClient

* refactor: remove unused events

* feat: add proposal simulator interface function and tests (#4466)

Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>

* refactor!: remove UpgradeProposal type (#4602)

* create separate event emission for ibc software upgrades vs an upgraded client (#4594)

* add new event type

* update event name

* fix build

* remove: legacy event emissions

* remove: unnecessary assignments, apply suggestion from code review

* e2e: schedule IBC software upgrade (#4585)

* wip e2e test

* query proposal

* update upgrade height in plan

* rm unnecessary wait/authority

* rm test artifact from merge

* add checks for scheduled plan

* hook up upgrade query client

* plan height

* pr fixes

* update test

* import space

* update newchainID value

* update clientID upgrade

* linter

* gci

* rm unnecessary event

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Sishir Giri <sis1001@berkeley.edu>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: Cian Hatton <cian@interchain.io>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Co-authored-by: catShaark <gundamaster5@gmail.com>
Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com>

* chore: docs for MsgIBCSoftwareUpgrade (#4601)

* chore: update docs for UpgradeProposal -> MsgIBCSoftwareUpgrade

* chore: anticipate link change

* fix event docs

* refactor: s.Assert -> s.Require

* Apply suggestions from code review

Co-authored-by: Damian Nolan <damiannolan@gmail.com>

* make proto-all

* chore: update compiler assertion

* refactor: ordering, order as follows: create, update, upgrade, misbheaviour, recover, ibcsoftwareupgrade, update params

* refactor: simplify ibc software upgrade emitted event

* lint lint lint

* Apply suggestions from code review

Co-authored-by: Charly <charly@interchain.io>

* review of feat/govv1

* pr nits

* fix tests for error wrapping

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Charly <charly@interchain.io>
Co-authored-by: Charly <charly@interchain.berlin>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sishir Giri <sis1001@berkeley.edu>
Co-authored-by: Cian Hatton <cian@interchain.io>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Co-authored-by: catShaark <gundamaster5@gmail.com>
Co-authored-by: khanh-notional <50263489+catShaark@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleenfei charleenfei charleenfei approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srdtrk @DimitrisJim @chatton @damiannolan @charleenfei @crodriguezvega