Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(ica/host): implemented 'PacketDataUnmarshaler' #4587

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Sep 6, 2023

Description

closes: #4582

Commit Message / Changelog Entry

imp(ica/host): implemented 'PacketDataUnmarshaler'

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@srdtrk srdtrk added 27-interchain-accounts type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. adr8 labels Sep 6, 2023
@srdtrk srdtrk added the v8 label Sep 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #4587 (c4b0e72) into main (2bb4cfd) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4587      +/-   ##
==========================================
+ Coverage   79.25%   79.26%   +0.01%     
==========================================
  Files         188      188              
  Lines       13064    13071       +7     
==========================================
+ Hits        10354    10361       +7     
  Misses       2276     2276              
  Partials      434      434              
Files Changed Coverage Δ
...les/apps/27-interchain-accounts/host/ibc_module.go 92.30% <100.00%> (+1.19%) ⬆️

@colin-axner colin-axner removed the v8 label Sep 7, 2023
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srdtrk srdtrk merged commit b53bfa5 into main Sep 11, 2023
@srdtrk srdtrk deleted the serdar/issue#4582-unmarshaler-interface-icahost branch September 11, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts adr8 type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PacketDataUnmarshaler Interface in ica/host
4 participants