-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run-e2e.sh #4624
Fix run-e2e.sh #4624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, thanks @chatton! :)
Looks like runners don't have |
@damiannolan script works as intended so 👯 |
…-jq-or-fzf-are-not-installed
…-jq-or-fzf-are-not-installed
…-jq-or-fzf-are-not-installed
@colin-axner turns out the runners didn't have fzf :D, updated the script, let me know if you're okay with the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Description
closes: #4600
Quick fix for the e2e script. The existing logic had good intentions but did work 😓
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.