Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs for gov v1 migration #4628

Merged
merged 11 commits into from
Sep 18, 2023
Merged

Adding docs for gov v1 migration #4628

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cd37676
docs: adding docs for gov v1 migration
chatton Sep 12, 2023
f897bfc
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton Sep 12, 2023
a8d1d71
chore: adding note about authority
chatton Sep 12, 2023
a0c8b8d
chore: run upgrade tests when upgrade_test.go changes
chatton Sep 12, 2023
4cfca8b
Revert "chore: run upgrade tests when upgrade_test.go changes"
chatton Sep 12, 2023
1f3de91
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton Sep 12, 2023
43d9ae6
formatting of code
Sep 12, 2023
3fde33e
chore: addressing PR feedback
chatton Sep 14, 2023
89bdefb
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton Sep 14, 2023
1408613
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton Sep 18, 2023
62d9e58
Merge branch 'main' into cian/issue#4544-migration-docs-for-v8-govv1
chatton Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions docs/migrations/v7-to-v8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,37 @@ Each module has a corresponding `MsgUpdateParams` message with a `Params` which

Legacy params subspaces must still be initialised in app.go in order to successfully migrate from x/params to the new self-contained approach. See reference: https://github.com/cosmos/ibc-go/blob/main/testing/simapp/app.go#L1001-L1006

### Governance V1 migration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we say something about making sure the correct authority is set in the ibc module keeper on app.go, and that it will default to gov if not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call


Proposals have been migrated to [gov v1 messages](https://docs.cosmos.network/v0.50/modules/gov#messages) ref: [#4620](https://github.com/cosmos/ibc-go/pull/4620).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Proposals have been migrated to [gov v1 messages](https://docs.cosmos.network/v0.50/modules/gov#messages) ref: [#4620](https://github.com/cosmos/ibc-go/pull/4620).
Proposals have been migrated to [gov v1 messages](https://docs.cosmos.network/v0.50/modules/gov#messages) ref: [#4620](https://github.com/cosmos/ibc-go/pull/4620). The proposal `ClientUpdateProposal` has been removed and replaced with `MsgRecoverClient` and the proposal `UpgradeProposal` has been removed and replaced with MsgIBCSoftwareUpgrade`.


Remove legacy proposal registration from app.go ref: [#4602](https://github.com/cosmos/ibc-go/pull/4602).

Remove the ibcclient ProposalHandler from the govRouter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove the ibcclient ProposalHandler from the govRouter.
Remove the 02-client proposal handler from the `govRouter`.


```diff
govRouter := govv1beta1.NewRouter()
govRouter.AddRoute(govtypes.RouterKey, govv1beta1.ProposalHandler).
AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also able to remove this from app.go now? for param change proposals?

- AddRoute(ibcclienttypes.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper))
```

Remove the UpgradeProposalHandler from the BasicModuleManager

```diff
app.BasicModuleManager = module.NewBasicManagerFromManager(
app.ModuleManager,
map[string]module.AppModuleBasic{
genutiltypes.ModuleName: genutil.NewAppModuleBasic(genutiltypes.DefaultMessageValidator),
govtypes.ModuleName: gov.NewAppModuleBasic(
[]govclient.ProposalHandler{
paramsclient.ProposalHandler,
- ibcclientclient.UpgradeProposalHandler,
},
),
})
```

### Transfer migration

An automatic migration handler (TODO: add link after https://github.com/cosmos/ibc-go/pull/3104 is merged) is configured in the transfer module to set the [denomination metadata](https://github.com/cosmos/cosmos-sdk/blob/95178ce036741ae6aa7af131fa9fccf3e13fff7a/proto/cosmos/bank/v1beta1/bank.proto#L96-L125) for the IBC denominations of all vouchers minted by the transfer module.
Expand Down
Loading