-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ADR8 #4631
Update ADR8 #4631
Conversation
The callback will then be routed through the callback keeper which will either panic or return a result (success or failure). In the event of a panic or an error, the callback state changes | ||
are discarded and the transaction is committed. | ||
|
||
If the transaction runs out of gas because the relayer-defined limit was exceeded the entire transaction is reverted to allow for resubmission. If the chain-defined or user-defined gas limit is reached, | ||
the callback state changes are reverted and the transaction is committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The panic/revert/commit behavior is the part I need double checked specifically. @srdtrk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AdityaSripal, left some questions and suggestions.
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
…ditya/adr-8-update
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much. Just left a couple more nits
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick skim, looks good. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reads good to me, left minor typo suggestions
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
* update adr8 to latest implementation decisions * fix link * fixed relationship between CallbackPacketData and packet data interfaces * update changelog * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * fix(docs): fix broken link * address rest of comments * Update docs/architecture/adr-008-app-caller-cbs.md Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> (cherry picked from commit 68f7ab3) # Conflicts: # docs/architecture/README.md
* docs: update ADR8 (#4631) * update adr8 to latest implementation decisions * fix link * fixed relationship between CallbackPacketData and packet data interfaces * update changelog * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * fix(docs): fix broken link * address rest of comments * Update docs/architecture/adr-008-app-caller-cbs.md Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: srdtrk <srdtrk@hotmail.com> Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com> (cherry picked from commit 68f7ab3) # Conflicts: # docs/architecture/README.md * Update README.md --------- Co-authored-by: Aditya <adityasripal@gmail.com>
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.