Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: use hermes master docker image #4643

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Conversation

crodriguezvega
Copy link
Contributor

Description

As requested by Romain to test the fix for informalsystems/hermes#3580 works fine.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @crodriguezvega and @romac for the new image!
Do we want to merge this as is or keep it open until a release version is available?

@crodriguezvega
Copy link
Contributor Author

Do we want to merge this as is or keep it open until a release version is available?

I am fine merging it as is and update when v1.7 is available.

@colin-axner
Copy link
Contributor

Only concern with using master is having e2e's fail suddenly, benefit of using a tag is that you don't have to worry about debugging recent changes

e2e/sample.config.yaml Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega deleted the carlos/use-hermes-image branch September 14, 2023 06:28
@crodriguezvega crodriguezvega restored the carlos/use-hermes-image branch September 14, 2023 11:31
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK

@crodriguezvega crodriguezvega merged commit 4ef9186 into main Sep 14, 2023
55 checks passed
@crodriguezvega crodriguezvega deleted the carlos/use-hermes-image branch September 14, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants