-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hygiene :rebind loop variable and wrap the actual test logic inside in suite.Run() #4658
hygiene :rebind loop variable and wrap the actual test logic inside in suite.Run() #4658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR @trinitys7, just left one initial comment as CI job for capability tests are failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @trinitys7. One comment for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trinitys7!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm considering comments left in other reviews
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
==========================================
+ Coverage 79.73% 79.77% +0.04%
==========================================
Files 187 189 +2
Lines 13195 13231 +36
==========================================
+ Hits 10521 10555 +34
- Misses 2246 2248 +2
Partials 428 428
|
@trinitys7 if you can rebase with main, then we will merge the PR. Thank you! |
Description
closes: #4419
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.