Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hygiene :rebind loop variable and wrap the actual test logic inside in suite.Run() #4658

Merged
merged 14 commits into from
Sep 22, 2023

Conversation

trinitys7
Copy link
Contributor

Description

  • rebind loop variable in tests
  • wrap the actual test logic inside in suite.Run()

closes: #4419


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @trinitys7, just left one initial comment as CI job for capability tests are failing.

modules/capability/simulation/decoder_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @trinitys7. One comment for now.

modules/apps/transfer/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trinitys7!

modules/apps/transfer/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
modules/core/02-client/types/height_test.go Outdated Show resolved Hide resolved
modules/core/03-connection/types/version_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm considering comments left in other reviews

trinitys7 and others added 3 commits September 21, 2023 01:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #4658 (dfc90d4) into main (8baeb7f) will increase coverage by 0.04%.
Report is 5 commits behind head on main.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4658      +/-   ##
==========================================
+ Coverage   79.73%   79.77%   +0.04%     
==========================================
  Files         187      189       +2     
  Lines       13195    13231      +36     
==========================================
+ Hits        10521    10555      +34     
- Misses       2246     2248       +2     
  Partials      428      428              
Files Changed Coverage Δ
modules/core/02-client/types/legacy_proposal.go 92.85% <92.85%> (ø)
modules/core/02-client/proposal_handler.go 100.00% <100.00%> (ø)

@crodriguezvega
Copy link
Contributor

@trinitys7 if you can rebase with main, then we will merge the PR. Thank you!

@crodriguezvega crodriguezvega merged commit e443a88 into cosmos:main Sep 22, 2023
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consistenly rebind loop variable in tests
5 participants