Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update protodoc strings #4679

Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 16, 2023

Description

This PR updates protodoc strings to omit the claim that governance is the default signer / authority.

closes: #4668

Commit Message / Changelog Entry

chore: omit governance as the default signer in protodoc strings

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@faddat faddat marked this pull request as draft September 16, 2023 13:54
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir!

@damiannolan damiannolan marked this pull request as ready for review September 18, 2023 11:20
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended the doc for SoftwareUpgrade message which was missed, lgtm

@colin-axner colin-axner enabled auto-merge (squash) September 18, 2023 15:57
@colin-axner colin-axner merged commit fec13d9 into cosmos:main Sep 18, 2023
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all protodoc strings of MsgUpdateParams
5 participants