Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix deploy-docs action #4726

Merged
merged 1 commit into from
Sep 20, 2023
Merged

ci: fix deploy-docs action #4726

merged 1 commit into from
Sep 20, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Sep 20, 2023

Description

closes: #XXXX

Commit Message / Changelog Entry

ci: fix deploy-docs action

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@srdtrk srdtrk added docs Improvements or additions to documentation github_actions Pull requests that update Github_actions code labels Sep 20, 2023
@srdtrk srdtrk merged commit 83d217c into main Sep 20, 2023
58 checks passed
- name: Build website
run: npm run build
run: make build-docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is make on the system?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other workflows seems to use it

@srdtrk srdtrk deleted the serdar/fix-docs-deploy-1 branch September 20, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants