chore: adding legacy gov proposal handler for client updates #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4729 +/- ##
==========================================
+ Coverage 79.73% 79.77% +0.04%
==========================================
Files 187 189 +2
Lines 13195 13231 +36
==========================================
+ Hits 10521 10555 +34
- Misses 2246 2248 +2
Partials 428 428 |
9 tasks
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
chatton and
DimitrisJim
as code owners
damiannolan
commented
Sep 20, 2023
| @@ -437,9 +437,8 @@ func getGenesisModificationFunction(cc ChainConfig) func(ibc.ChainConfig, []byte | |||
| // defaultGovv1ModifyGenesis will only modify governance params to ensure the voting period and minimum deposit | |||
| // are functional for e2e testing purposes. | |||
| func defaultGovv1ModifyGenesis(version string) func(ibc.ChainConfig, []byte) ([]byte, error) { | |||
| var stdlibJSONMarshalling = semverutil.FeatureReleases{MajorVersion: "v8"} | |||
| stdlibJSONMarshalling := semverutil.FeatureReleases{MajorVersion: "v8"} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding back the legacy v1beta1 gov proposal handler.
ref: #4721
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.