-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure list of relayers instead of single one #4737
Merged
chatton
merged 12 commits into
main
from
cian/issue#3981-tweak-config-file-to-allow-easy-toggling-of-relayers
Sep 25, 2023
Merged
Configure list of relayers instead of single one #4737
chatton
merged 12 commits into
main
from
cian/issue#3981-tweak-config-file-to-allow-easy-toggling-of-relayers
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asy-toggling-of-relayers
…asy-toggling-of-relayers
…g-of-relayers' of https://github.com/cosmos/ibc-go into cian/issue#3981-tweak-config-file-to-allow-easy-toggling-of-relayers
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
DimitrisJim
as code owners
September 21, 2023 09:31
srdtrk
approved these changes
Sep 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
damiannolan
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
DimitrisJim
reviewed
Sep 25, 2023
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
DimitrisJim
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
chatton
deleted the
cian/issue#3981-tweak-config-file-to-allow-easy-toggling-of-relayers
branch
September 25, 2023 10:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #3981
Improves configuration options for running E2Es, a future PR will update the tests to use this approach
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.