Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fee): fixed fee ModuleCdc's godocs #4759

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

srdtrk
Copy link
Member

@srdtrk srdtrk commented Sep 25, 2023

Description

godocs refer to transfer instead of 29-fee

closes: #XXXX

Commit Message / Changelog Entry

docs(fee): fixed fee ModuleCdc's godocs

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@srdtrk srdtrk added the docs Improvements or additions to documentation label Sep 25, 2023
@srdtrk srdtrk added the 29-fee label Sep 25, 2023
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@crodriguezvega crodriguezvega merged commit 5174891 into main Sep 25, 2023
59 checks passed
@crodriguezvega crodriguezvega deleted the serdar/nit-fee-cdc-godocs branch September 25, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-fee docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants