Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix to remove the option of generating a wasm tm client #4814

Closed
wants to merge 1 commit into from

Conversation

charleenfei
Copy link
Contributor

Description

part of the work in #4801

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #4814 (5a62616) into cian/merge-main-wasm (e9c0862) will increase coverage by 0.08%.
Report is 4 commits behind head on cian/merge-main-wasm.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           cian/merge-main-wasm    #4814      +/-   ##
========================================================
+ Coverage                 79.78%   79.87%   +0.08%     
========================================================
  Files                       189      189              
  Lines                     13264    13249      -15     
========================================================
- Hits                      10583    10582       -1     
+ Misses                     2254     2242      -12     
+ Partials                    427      425       -2     

see 1 file with indirect coverage changes

@@ -22,13 +22,12 @@ type TendermintConfig struct {
IsWasmClient bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this too?

Were all of the other fields also removed? I believe there was something attached to the Coorindator struct specfic to wasm clients also

Base automatically changed from cian/merge-main-wasm to feat/wasm-clients October 4, 2023 12:51
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, but there's other logic that can be removed as well, such as chain.SetWasm()

@charleenfei
Copy link
Contributor Author

ACK, but there's other logic that can be removed as well, such as chain.SetWasm()

ACK, but there's other logic that can be removed as well, such as chain.SetWasm()

pulling on threads and unravelling -- ill push these changes to this pr as well!

@colin-axner
Copy link
Contributor

closing as changes are included in #4804

@colin-axner colin-axner closed this Oct 4, 2023
@crodriguezvega crodriguezvega deleted the fix/rm_tendermintwasm branch July 9, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants