Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove grandpa unit test contract, rm test_data. #5150

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Remove grandpa unit test contract, rm test_data. #5150

merged 4 commits into from
Nov 21, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

Second part to remove grandpa contract.

closes: #5148

Commit Message / Changelog Entry

test: remove grandpa contract, remove test_data folder.

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Base automatically changed from jim/rm-tendermint-contract to main November 21, 2023 15:54
@DimitrisJim DimitrisJim marked this pull request as ready for review November 21, 2023 15:57
damiannolan
damiannolan approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

colin-axner
colin-axner approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice

@DimitrisJim DimitrisJim enabled auto-merge (squash) November 21, 2023 16:13
@DimitrisJim DimitrisJim merged commit c54ec07 into main Nov 21, 2023
71 of 72 checks passed
@DimitrisJim DimitrisJim deleted the jim/rm-grandpa-contract branch November 21, 2023 16:18
mergify bot pushed a commit that referenced this pull request Nov 29, 2023
@DimitrisJim @mergify
Remove grandpa unit test contract, rm test_data. (#5150)
ee0c1cb 
* Remove stored wasm contract in test_data.

* Remove grandpa unit test contract, rm test_data.

(cherry picked from commit c54ec07)
@mergify mergify bot mentioned this pull request Nov 29, 2023
Merged
crodriguezvega pushed a commit that referenced this pull request Nov 30, 2023
@mergify @DimitrisJim
Remove grandpa unit test contract, rm test_data. (#5150) (#5257)
40186f9 
* Remove stored wasm contract in test_data.

* Remove grandpa unit test contract, rm test_data.

(cherry picked from commit c54ec07)

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
crodriguezvega pushed a commit that referenced this pull request Nov 30, 2023
Remove grandpa unit test contract, rm test_data (backport #5150)
aea82ef
DimitrisJim added a commit that referenced this pull request Nov 30, 2023
@DimitrisJim
Remove grandpa unit test contract, rm test_data (backport #5150) (#5259)
9527f78 
* Remove grandpa unit test contract, rm test_data (backport #5150)

* add GenerateString function

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@charleenfei charleenfei Awaiting requested review from charleenfei

@chatton chatton Awaiting requested review from chatton

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
08-wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove contracts stored in test_data
4 participants
@DimitrisJim @damiannolan @colin-axner @crodriguezvega