Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newest linter complaints #5156

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix newest linter complaints #5156

merged 2 commits into from
Nov 22, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

linter currently doesn't run on e2e code + capability so make lint will always have sweet surprises for us unless we add linting to workflow.

closes: #XXXX

Commit Message / Changelog Entry

chore: make lint-fix to fix linting errors.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love linter surprises! ;)

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chatton
Copy link
Contributor

chatton commented Nov 22, 2023

@crodriguezvega love is a strong word for linter surprises 😅

@DimitrisJim DimitrisJim enabled auto-merge (squash) November 22, 2023 12:14
@DimitrisJim DimitrisJim merged commit 9e203b8 into main Nov 22, 2023
70 of 72 checks passed
@DimitrisJim DimitrisJim deleted the jim/make-lint-fix branch November 22, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capability Issues for capability modules e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants