Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wasm tests on forks #5234

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Nov 29, 2023

Description

closes: #5124

This PR updates the fork workflow to run grandpa client tests

Test run here: https://github.com/cosmos/ibc-go/actions/runs/7031532342


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Nov 29, 2023
@github-actions github-actions bot added the e2e label Nov 29, 2023
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this overall looks good to me, hopefully all hell wont break lose when it actually runs 😄

@DimitrisJim DimitrisJim merged commit 54e2172 into main Dec 4, 2023
70 of 71 checks passed
@DimitrisJim DimitrisJim deleted the cian/update-fork-workflow-to-run-wasm-tests branch December 4, 2023 17:36
damiannolan added a commit that referenced this pull request Dec 5, 2023
* chore: support wasm tests on forks

* chore: use correct needs

* chore: install python deps

* chore: adding flag for forks

* chore: use chain image passed in CI

* Update e2e/testsuite/testconfig.go

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wasm simd image for E2Es run on forks
3 participants