Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetSigners from sdk.Msg implementations #5305

Merged
merged 15 commits into from
Dec 6, 2023

Conversation

ThanhNhann
Copy link
Contributor

@ThanhNhann ThanhNhann commented Dec 4, 2023

Description

partially addresses: #4687


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@DimitrisJim
Copy link
Contributor

no worries w.r.t pull request labeler, you can run make lint/make lint-fix for linter complains.

@DimitrisJim
Copy link
Contributor

note, also grepped for it and found GetSigners for a mock message, see: ./modules/apps/27-interchain-accounts/types/codec_test.go:40

I'd assume that can also probably be safely dropped.

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I just commented on some more tests which could be refactored to remove the suite receiver and use moduletestutil.MakeTestEncodingConfig

Happy to merge after those are addressed 🚀

modules/apps/transfer/types/msgs_test.go Outdated Show resolved Hide resolved
modules/core/02-client/types/msgs_test.go Outdated Show resolved Hide resolved
modules/core/03-connection/types/msgs_test.go Outdated Show resolved Hide resolved
@ThanhNhann
Copy link
Contributor Author

Updated, thank @damiannolan for your suggestions ❤️

modules/apps/transfer/types/msgs_test.go Outdated Show resolved Hide resolved
modules/core/02-client/types/msgs_test.go Outdated Show resolved Hide resolved
modules/core/02-client/types/msgs_test.go Outdated Show resolved Hide resolved
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK finishing touches, thank you @ThanhNhann! 🚀

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left one minor nit while going through changes

modules/apps/transfer/types/msgs_test.go Outdated Show resolved Hide resolved
@damiannolan damiannolan enabled auto-merge (squash) December 6, 2023 14:55
@damiannolan damiannolan disabled auto-merge December 6, 2023 14:57
@damiannolan damiannolan merged commit b04b843 into cosmos:main Dec 6, 2023
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants