-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GetSigners from sdk.Msg
implementations
#5305
Conversation
no worries w.r.t pull request labeler, you can run |
modules/apps/27-interchain-accounts/controller/types/msgs_test.go
Outdated
Show resolved
Hide resolved
…/ibc-go into nhan/remove_GetSigners
note, also grepped for it and found GetSigners for a mock message, see: ./modules/apps/27-interchain-accounts/types/codec_test.go:40 I'd assume that can also probably be safely dropped. |
modules/apps/27-interchain-accounts/controller/types/msgs_test.go
Outdated
Show resolved
Hide resolved
modules/apps/27-interchain-accounts/controller/types/msgs_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I just commented on some more tests which could be refactored to remove the suite
receiver and use moduletestutil.MakeTestEncodingConfig
Happy to merge after those are addressed 🚀
Updated, thank @damiannolan for your suggestions ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK finishing touches, thank you @ThanhNhann! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left one minor nit while going through changes
Description
partially addresses: #4687
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.