Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require authority to pass proof if channel state is in FLUSHCOMPLETE for upgrade cancellation #5332

Conversation

charleenfei
Copy link
Contributor

Description

closes: #5319

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks!

Should we have a test case for:
sender is authority, error receipt sequence less than channel upgrade sequence

I see the test case when the sender isn't authority, but it might be nice to have the authority case as well

@charleenfei charleenfei merged commit 4a3d0a5 into 04-channel-upgrades Dec 7, 2023
55 checks passed
@charleenfei charleenfei deleted the charly/issue#5319-require-authority-to-pass-proof-if-self-channel-state-is-in-flushcomplete-for-upgrade-cancellation branch December 7, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants