Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end of life for v6 #5341

Merged
merged 4 commits into from
Dec 12, 2023
Merged

end of life for v6 #5341

merged 4 commits into from
Dec 12, 2023

Conversation

crodriguezvega
Copy link
Contributor

Description

To be merged after December 9th.

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the memo e2e logic now

var MemoFeatureReleases = semverutil.FeatureReleases{

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! Forgot this as marked as good to go after Dec 9th.

LGTM!

@crodriguezvega
Copy link
Contributor Author

I think we can simplify the memo e2e logic now

var MemoFeatureReleases = semverutil.FeatureReleases{

I removed the code related to check the version for this: 2a366d0

@crodriguezvega crodriguezvega merged commit 3e1998f into main Dec 12, 2023
63 checks passed
@crodriguezvega crodriguezvega deleted the carlos/eol-v6 branch December 12, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants