Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ChanUpgradeInit and governance gating #5347

Conversation

charleenfei
Copy link
Contributor

Description

closes: #5270

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

charleenfei and others added 5 commits December 11, 2023 10:03
…age-of-authority-gated-msgchannelupgradeinit
…channelupgradeinit' of github.com:cosmos/ibc-go into charly/issue#5270-document-usage-of-authority-gated-msgchannelupgradeinit
@crodriguezvega crodriguezvega added docs Improvements or additions to documentation channel-upgradability Channel upgradability feature labels Dec 13, 2023
…age-of-authority-gated-msgchannelupgradeinit
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small nits

docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see suggestions

docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
@charleenfei charleenfei merged commit d6408a3 into 04-channel-upgrades Dec 14, 2023
18 checks passed
@charleenfei charleenfei deleted the charly/issue#5270-document-usage-of-authority-gated-msgchannelupgradeinit branch December 14, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants