Remove GetSigners from module 04-channel
#5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanhNhann
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei,
chatton and
DimitrisJim
as code owners
3 tasks
DimitrisJim
approved these changes
Dec 11, 2023
damiannolan
reviewed
Dec 11, 2023
There was a problem hiding this comment.
Thank you @ThanhNhann! Looks great, just request to add some more tests if possible
There was a problem hiding this comment.
Looks like some tests for GetSigners are missing from this file, would you be able to add them? :)
There was a problem hiding this comment.
Sure, I will add them soon 🤝
There was a problem hiding this comment.
It would be nice to have tests for all messages, just so we'll have breakages if protobuf annotations are ever changed etc
damiannolan
approved these changes
Dec 11, 2023
colin-axner
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks @ThanhNhann! I noticed two small details, but I'm happy as is
…m/decentrio/ibc-go into nhan/remove_GetSigners_04_channel
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4687
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.