fix: set upgrade sequence correctly in channel recovery #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
…ancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
charleenfei
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
charleenfei
force-pushed
the
charly/issue#5340-authority-cancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
branch
from
44bc2a3 to
cf83651
Compare
…ancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
colin-axner
reviewed
Dec 13, 2023
colin-axner
reviewed
Dec 13, 2023
colin-axner
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
LGTM, left a suggestion on another test case and doc improvement. Would be great to have an ACK from @chatton or @damiannolan on the approach since I think they worked on some of this flow
damiannolan
requested changes
Dec 14, 2023
There was a problem hiding this comment.
ACK pending API update for removing isAuthority bool and @colin-axner's suggestions! :)
…ancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
…ancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
damiannolan
approved these changes
Dec 14, 2023
charleenfei
deleted the
charly/issue#5340-authority-cancelling-upgrade-can-lead-to-accidental-resets-of-the-upgrade-sequence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5340
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.