Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk.MustSortJSON from channel types Acknowledgement #5377

Merged
merged 10 commits into from
Dec 21, 2023
Merged

Remove sdk.MustSortJSON from channel types Acknowledgement #5377

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d50c0d7
nguyen/remove-MustSortJson-types-Acknowledgement
expertdicer Dec 12, 2023
46f78ab
remove MustSortJson
expertdicer Dec 13, 2023
b5e6b2b
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
lacsomot Dec 13, 2023
9198ebe
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
expertdicer Dec 18, 2023
b4a9649
using SubModuleCdc.MustMarshalJSON
expertdicer Dec 18, 2023
1e6f393
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
expertdicer Dec 19, 2023
1675a2f
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
expertdicer Dec 19, 2023
7cc6781
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
DimitrisJim Dec 20, 2023
f5c0fdf
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
DimitrisJim Dec 20, 2023
de91234
Merge branch 'main' into nguyen/remove-MustSortJson-types-Acknowledge…
expertdicer Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions modules/core/04-channel/types/acknowledgement.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import (
"strings"

errorsmod "cosmossdk.io/errors"

sdk "github.com/cosmos/cosmos-sdk/types"
)

const (
Expand Down Expand Up @@ -70,5 +68,5 @@ func (ack Acknowledgement) Success() bool {
// Acknowledgement implements the Acknowledgement interface. It returns the
// acknowledgement serialised using JSON.
func (ack Acknowledgement) Acknowledgement() []byte {
return sdk.MustSortJSON(SubModuleCdc.MustMarshalJSON(&ack))
return SubModuleCdc.MustMarshalJSON(&ack)
}
Loading