Collect hermes config.toml file in e2e diagnostics #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
DimitrisJim
as code owners
chatton
commented
Dec 14, 2023
Comment on lines
-138
to
-144
| s.T().Cleanup(func() { | ||
| if !s.T().Failed() { | ||
| if err := relayer.StopRelayer(ctx, eRep); err != nil { | ||
| s.T().Logf("error stopping relayer: %v", err) | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
this block isn't required as the containers are cleaned up at the end of the tests anyway. This was also removing the hermes container before the logs would be collected.
colin-axner
approved these changes
Dec 14, 2023
damiannolan
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some additional debugging information by collecting the hermes config.toml file.
I removed some of the more verbose logging which I don't think added much value. (if anything it made things worse 😅 )
note: you must specify
In the e2e config for the logs to be collected if the test passes.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.