feat(statemachine)!: Add allow all client wildcard to AllowedClients param #5429

sontrinh16 · 2023-12-17T15:52:27Z

Description

All allow all client type wildcard

Overview

closes: #5316

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md).
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards and Go style guide.
Wrote unit and integration tests.
Updated relevant documentation (docs/) or specification (x/<module>/spec/).
Added relevant godoc comments.
Provide a commit message to be used for the changelog entry in the PR description for review.
Re-reviewed Files changed in the Github PR explorer.
Review Codecov Report in the comment section below once CI passes.

codecov-commenter · 2023-12-17T15:57:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd5b172) 81.18% compared to head (93f07ea) 81.19%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5429      +/-   ##
==========================================
+ Coverage   81.18%   81.19%   +0.01%     
==========================================
  Files         197      197              
  Lines       15247    15257      +10     
==========================================
+ Hits        12378    12388      +10     
  Misses       2404     2404              
  Partials      465      465

Files	Coverage Δ
modules/core/02-client/types/keys.go	`75.00% <ø> (ø)`
modules/core/02-client/types/params.go	`100.00% <100.00%> (ø)`

chatton

LGTM thank you!

…he allow list

crodriguezvega

Thank you, @sontrinh16

damiannolan · 2023-12-20T11:54:15Z

Is the intension to backport this @crodriguezvega?

Otherwise we'll experience e2e test failures in ibcwasm v7.3 with the e2e diffs in this PR. The gov proposals for adding 08-wasm to allowed clients may need to be wrapped in a feature releases struct to add multi version support

crodriguezvega · 2023-12-20T22:48:50Z

@damiannolan I think with these changes it is working. I took the code from this other PR, so I will add @expertdicer as co-author when I merge it.

phamminh0811 · 2023-12-21T03:01:41Z

Hi @crodriguezvega, I think that I'm the main author of this PR, not @expertdicer.

expertdicer · 2023-12-21T05:42:08Z

Our avatars have some differents. 😄

crodriguezvega · 2023-12-21T09:36:05Z

Our avatars have some differents. 😄

oh, sorry, yes. The icons looked the same in small size. 😅

damiannolan

Thank you! 🚀

damiannolan · 2023-12-21T12:56:48Z

e2e/testvalues/values.go

+
+// AllowAllClientsWildcardFeatureReleases represents the releases the allow all clients wildcard was released in.
+var AllowAllClientsWildcardFeatureReleases = semverutil.FeatureReleases{
+	MajorVersion: "v9",


Couldn't we add this feature in v8.1?

I think we could!

I left v9 as the major version and added v8.1 in the minor versions.

Also added the backport label

Let me update the docs before merging, because we probably have a few places where we should now mention that you don't need to update the allowed clients if you add a new client.

damiannolan

ACK docs changes, thanks @crodriguezvega

DimitrisJim

sweet! 🍬

…param (#5429) * add wildcard allow all client * minor * fix lint * minor and doc update * review comments * if allow all clients is present, no other client types should be in the allow list * clean up code to allow wasm client type * remove unused variable * Fix build failures, tweak err message. * modify allow clients list in genesis with feature releases * chore: adding v8.1 to minor versions in e2e feat releases struct * update docs * chore: doc lint fixes --------- Co-authored-by: GnaD <89174180+GNaD13@users.noreply.github.com> Co-authored-by: Du Nguyen <61083705+lichdu29@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Đỗ Việt Hoàng <hoangdv2429@gmail.com> Co-authored-by: Charly <charly@interchain.io> (cherry picked from commit d5949b1) # Conflicts: # docs/docs/03-light-clients/04-wasm/03-integration.md # e2e/tests/wasm/grandpa_test.go # e2e/testsuite/testconfig.go # e2e/testvalues/values.go # modules/core/02-client/types/params.go # modules/core/02-client/types/params_test.go # modules/light-clients/08-wasm/keeper/keeper_test.go # modules/light-clients/08-wasm/testing/wasm_endpoint.go # modules/light-clients/08-wasm/types/types_test.go

…param (backport #5429) (#5609) * feat(statemachine)!: Add allow all client wildcard to AllowedClients param (#5429) * add wildcard allow all client * minor * fix lint * minor and doc update * review comments * if allow all clients is present, no other client types should be in the allow list * clean up code to allow wasm client type * remove unused variable * Fix build failures, tweak err message. * modify allow clients list in genesis with feature releases * chore: adding v8.1 to minor versions in e2e feat releases struct * update docs * chore: doc lint fixes --------- Co-authored-by: GnaD <89174180+GNaD13@users.noreply.github.com> Co-authored-by: Du Nguyen <61083705+lichdu29@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Đỗ Việt Hoàng <hoangdv2429@gmail.com> Co-authored-by: Charly <charly@interchain.io> (cherry picked from commit d5949b1) # Conflicts: # docs/docs/03-light-clients/04-wasm/03-integration.md # e2e/tests/wasm/grandpa_test.go # e2e/testsuite/testconfig.go # e2e/testvalues/values.go # modules/core/02-client/types/params.go # modules/core/02-client/types/params_test.go # modules/light-clients/08-wasm/keeper/keeper_test.go # modules/light-clients/08-wasm/testing/wasm_endpoint.go # modules/light-clients/08-wasm/types/types_test.go * chore: rm -rf e2e * chore: rm -rf modules/light-clients/08-wasm * chore: fix conflicts in 02-client/types/params and tests * fix: validateClients duplicates * chore: rm -rf docs * chore: remove markdown link checker workflow from release branch * add changelog --------- Co-authored-by: son trinh <trinhleson2000@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

sontrinh16 added 2 commits December 17, 2023 03:19

add wildcard allow all client

26d5bfb

minor

58a5d82

sontrinh16 requested review from colin-axner, AdityaSripal and damiannolan as code owners December 17, 2023 15:52

fix lint

67836b7

minor and doc update

9a94db1

sontrinh16 requested review from crodriguezvega, charleenfei, chatton, DimitrisJim and srdtrk as code owners December 17, 2023 16:04

GNaD13 and others added 5 commits December 18, 2023 15:44

Merge branch 'main' into add_wildcard_allow_all_client

ff770e3

Merge branch 'main' into add_wildcard_allow_all_client

feaf533

Merge branch 'main' into add_wildcard_allow_all_client

d087f50

Merge branch 'main' into add_wildcard_allow_all_client

fb1920e

review comments

90a252e

chatton approved these changes Dec 19, 2023

View reviewed changes

sontrinh16 and others added 5 commits December 19, 2023 19:03

Merge branch 'main' into add_wildcard_allow_all_client

2600e80

Merge branch 'main' into add_wildcard_allow_all_client

d832839

if allow all clients is present, no other client types should be in t…

af912b6

…he allow list

clean up code to allow wasm client type

d224be2

remove unused variable

d98ed8b

crodriguezvega mentioned this pull request Dec 20, 2023

E2E: add 08-wasm into allowed clients at genesis #5440

Closed

9 tasks

DimitrisJim and others added 3 commits December 20, 2023 11:00

Fix build failures, tweak err message.

482ca8e

Merge branch 'main' into add_wildcard_allow_all_client

67d6ccd

Merge branch 'main' into add_wildcard_allow_all_client

861c9b6

crodriguezvega approved these changes Dec 20, 2023

View reviewed changes

crodriguezvega added 3 commits December 20, 2023 23:05

Merge branch 'main' into add_wildcard_allow_all_client

8be427e

Merge branch 'main' into add_wildcard_allow_all_client

9625eb5

modify allow clients list in genesis with feature releases

e736817

crodriguezvega changed the title ~~feat: Add allow all client wildcard to AllowedClients param~~ feat(statemachine)!: Add allow all client wildcard to AllowedClients param Dec 20, 2023

damiannolan approved these changes Dec 21, 2023

View reviewed changes

damiannolan and others added 6 commits December 21, 2023 13:57

Merge branch 'main' into add_wildcard_allow_all_client

a1c0868

Merge branch 'main' into add_wildcard_allow_all_client

a4728cd

Merge branch 'main' into add_wildcard_allow_all_client

da722e9

Merge branch 'main' into add_wildcard_allow_all_client

079ef2b

Merge branch 'main' into add_wildcard_allow_all_client

8d83328

chore: adding v8.1 to minor versions in e2e feat releases struct

a9ddbf1

damiannolan added the backport-to-v8.1.x label Jan 9, 2024

DimitrisJim and others added 7 commits January 9, 2024 21:16

Merge branch 'main' into add_wildcard_allow_all_client

955111c

Merge branch 'main' into add_wildcard_allow_all_client

1c4cb91

Merge branch 'main' into add_wildcard_allow_all_client

0563919

Merge branch 'main' into add_wildcard_allow_all_client

89ce4a6

update docs

7796dcf

chore: doc lint fixes

71323d4

Merge branch 'main' into add_wildcard_allow_all_client

a03702e

damiannolan approved these changes Jan 15, 2024

View reviewed changes

Merge branch 'main' into add_wildcard_allow_all_client

93f07ea

DimitrisJim approved these changes Jan 15, 2024

View reviewed changes

damiannolan merged commit d5949b1 into cosmos:main Jan 15, 2024
70 checks passed

mergify bot mentioned this pull request Jan 15, 2024

feat(statemachine)!: Add allow all client wildcard to AllowedClients param (backport #5429) #5609

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(statemachine)!: Add allow all client wildcard to AllowedClients param #5429

feat(statemachine)!: Add allow all client wildcard to AllowedClients param #5429

sontrinh16 commented Dec 17, 2023 •

edited

Loading

codecov-commenter commented Dec 17, 2023 •

edited

Loading

chatton left a comment

crodriguezvega left a comment

damiannolan commented Dec 20, 2023

crodriguezvega commented Dec 20, 2023

phamminh0811 commented Dec 21, 2023 •

edited

Loading

expertdicer commented Dec 21, 2023

crodriguezvega commented Dec 21, 2023

damiannolan left a comment

damiannolan Dec 21, 2023

crodriguezvega Jan 8, 2024

damiannolan Jan 9, 2024

crodriguezvega Jan 9, 2024

damiannolan left a comment

DimitrisJim left a comment

feat(statemachine)!: Add allow all client wildcard to AllowedClients param #5429

feat(statemachine)!: Add allow all client wildcard to AllowedClients param #5429

Conversation

sontrinh16 commented Dec 17, 2023 • edited Loading

Description

Overview

codecov-commenter commented Dec 17, 2023 • edited Loading

Codecov Report

chatton left a comment

Choose a reason for hiding this comment

crodriguezvega left a comment

Choose a reason for hiding this comment

damiannolan commented Dec 20, 2023

crodriguezvega commented Dec 20, 2023

phamminh0811 commented Dec 21, 2023 • edited Loading

expertdicer commented Dec 21, 2023

crodriguezvega commented Dec 21, 2023

damiannolan left a comment

Choose a reason for hiding this comment

damiannolan Dec 21, 2023

Choose a reason for hiding this comment

crodriguezvega Jan 8, 2024

Choose a reason for hiding this comment

damiannolan Jan 9, 2024

Choose a reason for hiding this comment

crodriguezvega Jan 9, 2024

Choose a reason for hiding this comment

damiannolan left a comment

Choose a reason for hiding this comment

DimitrisJim left a comment

Choose a reason for hiding this comment

sontrinh16 commented Dec 17, 2023 •

edited

Loading

codecov-commenter commented Dec 17, 2023 •

edited

Loading

phamminh0811 commented Dec 21, 2023 •

edited

Loading