Pass appVersion to callback if version can be parsed. #5468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
commented
Dec 19, 2023
| func() {}, | ||
| func() { | ||
| // Assert in callback that correct version is passed | ||
| suite.chainA.GetSimApp().FeeMockModule.IBCApp.OnChanUpgradeOpen = func(_ sdk.Context, _, _ string, _ channeltypes.Order, _ []string, version string) { |
There was a problem hiding this comment.
open to charming ideas on how I could test for this in a simpler way
There was a problem hiding this comment.
This looks like a good way to me. We could also make assertions on the other upgrade fields too cause why not!
There was a problem hiding this comment.
why not is true, added some additional assertions in there!
DimitrisJim
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
AdityaSripal
approved these changes
Dec 19, 2023
damiannolan
approved these changes
Dec 19, 2023
| func() {}, | ||
| func() { | ||
| // Assert in callback that correct version is passed | ||
| suite.chainA.GetSimApp().FeeMockModule.IBCApp.OnChanUpgradeOpen = func(_ sdk.Context, _, _ string, _ channeltypes.Order, _ []string, version string) { |
There was a problem hiding this comment.
This looks like a good way to me. We could also make assertions on the other upgrade fields too cause why not!
DimitrisJim
force-pushed
the
jim/5459-pass-app-version-to-next-app
branch
from
c6ca01a to
b1a29b3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5459
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.