Improving docstrings for UpgradableModule interface #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
colin-axner
reviewed
Dec 21, 2023
chatton
force-pushed
the
cian/issue#5466-update-documentation-on-upgradablemodule-interface-functions
branch
from
b210d72
to
c4781ba
Compare
chatton
requested review from
crodriguezvega,
charleenfei,
DimitrisJim and
srdtrk
as code owners
chatton
force-pushed
the
cian/issue#5466-update-documentation-on-upgradablemodule-interface-functions
branch
from
16fa22f
to
1e5d0c6
Compare
AdityaSripal
approved these changes
Jan 3, 2024
…adablemodule-interface-functions
…adablemodule-interface-functions
charleenfei
approved these changes
Jan 5, 2024
…adablemodule-interface-functions
…adablemodule-interface-functions
crodriguezvega
approved these changes
Jan 5, 2024
crodriguezvega
deleted the
cian/issue#5466-update-documentation-on-upgradablemodule-interface-functions
branch
crodriguezvega
pushed a commit
that referenced
this pull request
Jan 8, 2024
* chore: merge main * chore: corrected commit * Document ibc app expectations and recommendations (#5506) * fix typo --------- Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 26fd1e0) Co-authored-by: Cian Hatton <cian@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5466
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.