-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: channel upgradability (backport #1613) #5478
Merged
crodriguezvega
merged 11 commits into
release/v8.1.x
from
mergify/bp/release/v8.1.x/pr-1613
Dec 21, 2023
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
415646a
feat: channel upgradability (#1613)
damiannolan 2a5e290
chore: rm -rf e2e
damiannolan ae45f5e
chore: make proto-all to resolve authz transfer conflicts
damiannolan 10bcecc
chore: resolve remaining conflicts in src files
damiannolan 9a78f28
chore: regenerate swagger doc
damiannolan 172e177
chore: fix markdown links
damiannolan b75e3bf
add MsgPruneAcknowledgements
charleenfei 5392565
add compiler assertions for MsgPruneAcknowledgements
charleenfei c9ee628
changes to avoid breaking API for channel upgradability (#5480)
57c1b20
fix: add MsgPruneAcknowledgements to codec registration (#5481) (#5483)
mergify[bot] 5a21fe5
fix: remove api breaks on backport (#5484)
colin-axner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# golangci-feature runs on pull requests from branches that do not target main. | ||
# | ||
# Working on feature branches (PRs where the PR base-ref != main) is a common | ||
# workflow used, in order to make the merging of PRs easier certain lints are excluded | ||
# when it makes sense. Currently, unused lints are excluded since many PRs will add | ||
# unused code that will be used in a later PR. | ||
name: golangci-lint feature branch | ||
on: | ||
pull_request: | ||
# Ignore if the target is main. (Negation of golanci-lint.yml) | ||
branches-ignore: | ||
- main | ||
permissions: | ||
contents: read | ||
# Optional: allow read access to pull request. Use with `only-new-issues` option. | ||
# pull-requests: read | ||
|
||
jobs: | ||
golangci: | ||
name: lint | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.21' | ||
- uses: actions/checkout@v4 | ||
- name: golangci-lint | ||
uses: golangci/golangci-lint-action@v3.7.0 | ||
with: | ||
version: v1.54.2 | ||
args: --timeout 10m |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is probably unnecessary here, but also no problem