-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cli for MsgPruneAcknowledgements
#5482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one minor q about the long desc
I don't think your question was published in the review by the looks of thiings! 👀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5482 +/- ##
==========================================
+ Coverage 81.09% 81.27% +0.18%
==========================================
Files 197 197
Lines 15234 15234
==========================================
+ Hits 12354 12382 +28
+ Misses 2412 2391 -21
+ Partials 468 461 -7 |
(cherry picked from commit bf12ce3)
(cherry picked from commit bf12ce3) Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Description
MsgPruneAcknowledgements
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.