Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cli for MsgPruneAcknowledgements #5482

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Dec 21, 2023

Description

  • Added CLI for submitting MsgPruneAcknowledgements

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review January 8, 2024 10:35
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor q about the long desc

@damiannolan
Copy link
Member Author

lgtm, one minor q about the long desc

I don't think your question was published in the review by the looks of thiings! 👀

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26fd1e0) 81.09% compared to head (fbcd7d3) 81.27%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5482      +/-   ##
==========================================
+ Coverage   81.09%   81.27%   +0.18%     
==========================================
  Files         197      197              
  Lines       15234    15234              
==========================================
+ Hits        12354    12382      +28     
+ Misses       2412     2391      -21     
+ Partials      468      461       -7     

see 1 file with indirect coverage changes

@damiannolan damiannolan merged commit bf12ce3 into main Jan 8, 2024
61 checks passed
@damiannolan damiannolan deleted the damian/add-prune-acks-cli branch January 8, 2024 12:27
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
damiannolan added a commit that referenced this pull request Jan 8, 2024
(cherry picked from commit bf12ce3)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants