Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added tests for UpdateChannelParams #5494

Merged
merged 7 commits into from
Jan 3, 2024

Conversation

MukulKolpe
Copy link
Contributor

@MukulKolpe MukulKolpe commented Dec 23, 2023

Description

Added tests for UpdateChannelParams in msg_server_test.go.

closes: #5479

Commit Message / Changelog Entry

test: added tests for `UpdateChannelParams`

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c2996a) 80.88% compared to head (47e7163) 80.94%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5494      +/-   ##
==========================================
+ Coverage   80.88%   80.94%   +0.05%     
==========================================
  Files         197      197              
  Lines       15221    15221              
==========================================
+ Hits        12312    12320       +8     
+ Misses       2437     2429       -8     
  Partials      472      472              

see 1 file with indirect coverage changes

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm!

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks, @MukulKolpe.

@chatton chatton enabled auto-merge (squash) January 3, 2024 13:45
@chatton chatton merged commit 6736c09 into cosmos:main Jan 3, 2024
59 of 60 checks passed
@crodriguezvega crodriguezvega mentioned this pull request Jan 4, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for UpdateChannelParams
6 participants