-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameter names for better readability #5512
Update parameter names for better readability #5512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there a couple of places where we could do some extra renaming.
- Should we also do the renaming in the host callbacks and in the keeper functions of both the controller and host?
- Should we also do the renaming in the testing mock callbacks?
…etter-readability
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
=======================================
Coverage 81.18% 81.18%
=======================================
Files 197 197
Lines 15247 15247
=======================================
Hits 12378 12378
Misses 2404 2404
Partials 465 465
|
…etter-readability
…etter-readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK but see suggestions, some consistency is still missing. Thank you!
…etter-readability
* chore: renaming method fields * chore: rename more variables * chore: renamed fields in transfer module * chore: addressing PR feedback * more renaming --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 19564a4)
* chore: renaming method fields * chore: rename more variables * chore: renamed fields in transfer module * chore: addressing PR feedback * more renaming --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 19564a4) Co-authored-by: Cian Hatton <cian@interchain.io>
Description
closes: #5463
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.