Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameter names for better readability #5512

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jan 4, 2024

Description

closes: #5463


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@chatton chatton marked this pull request as ready for review January 4, 2024 09:46
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there a couple of places where we could do some extra renaming.

@chatton chatton requested a review from DimitrisJim as a code owner January 10, 2024 09:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (de8eb6e) 81.18% compared to head (c16f5b3) 81.18%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5512   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files         197      197           
  Lines       15247    15247           
=======================================
  Hits        12378    12378           
  Misses       2404     2404           
  Partials      465      465           
Files Coverage Δ
...interchain-accounts/controller/keeper/handshake.go 84.17% <100.00%> (ø)
modules/apps/29-fee/ibc_middleware.go 88.27% <100.00%> (ø)
...7-interchain-accounts/controller/ibc_middleware.go 69.56% <85.71%> (ø)
...ps/27-interchain-accounts/host/keeper/handshake.go 87.37% <85.71%> (ø)
modules/apps/transfer/ibc_module.go 69.10% <87.50%> (ø)
...les/apps/27-interchain-accounts/host/ibc_module.go 84.12% <50.00%> (ø)

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK but see suggestions, some consistency is still missing. Thank you!

modules/apps/27-interchain-accounts/host/ibc_module.go Outdated Show resolved Hide resolved
modules/apps/27-interchain-accounts/host/ibc_module.go Outdated Show resolved Hide resolved
modules/apps/27-interchain-accounts/host/ibc_module.go Outdated Show resolved Hide resolved
testing/mock/ibc_module.go Outdated Show resolved Hide resolved
modules/apps/callbacks/ibc_middleware.go Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit 19564a4 into main Jan 12, 2024
62 checks passed
@crodriguezvega crodriguezvega deleted the cian/issue#5463-update-parameter-names-for-better-readability branch January 12, 2024 15:24
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
* chore: renaming method fields

* chore: rename more variables

* chore: renamed fields in transfer module

* chore: addressing PR feedback

* more renaming

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 19564a4)
crodriguezvega pushed a commit that referenced this pull request Jan 12, 2024
* chore: renaming method fields

* chore: rename more variables

* chore: renamed fields in transfer module

* chore: addressing PR feedback

* more renaming

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
(cherry picked from commit 19564a4)

Co-authored-by: Cian Hatton <cian@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label args as upgrade parameters for better readability
6 participants