Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: missing upgrade msgs assertions #5515

Merged
merged 4 commits into from
Jan 8, 2024
Merged

chore: missing upgrade msgs assertions #5515

merged 4 commits into from
Jan 8, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

charleenfei
charleenfei approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @crodriguezvega !

DimitrisJim
DimitrisJim approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely caught!

@crodriguezvega crodriguezvega merged commit 339655e into main Jan 8, 2024
61 checks passed
@crodriguezvega crodriguezvega deleted the carlos/missing-upgrade-msgs-assertions branch January 8, 2024 11:34
mergify bot pushed a commit that referenced this pull request Jan 8, 2024
@crodriguezvega @mergify
chore: missing upgrade msgs assertions (#5515)
a2e5a18 
Co-authored-by: Charly <charly@interchain.io>
(cherry picked from commit 339655e)
@mergify mergify bot mentioned this pull request Jan 8, 2024
Merged
crodriguezvega added a commit that referenced this pull request Jan 8, 2024
@mergify @crodriguezvega
chore: missing upgrade msgs assertions (#5515) (#5542)
7dd842b 
Co-authored-by: Charly <charly@interchain.io>
(cherry picked from commit 339655e)

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@charleenfei charleenfei charleenfei approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

Assignees
No one assigned
Labels
channel-upgradability Channel upgradability feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crodriguezvega @DimitrisJim @charleenfei