add explicit checks in OnChanUpgradeTry callback of ICA host
#5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
added
channel-upgradability
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5519 +/- ##
==========================================
- Coverage 81.20% 81.19% -0.02%
==========================================
Files 197 197
Lines 15235 15253 +18
==========================================
+ Hits 12372 12384 +12
- Misses 2400 2404 +4
- Partials 463 465 +2
|
crodriguezvega
commented
Jan 4, 2024
| @@ -84,6 +85,15 @@ func (Keeper) Logger(ctx sdk.Context) log.Logger { | |||
| return ctx.Logger().With("module", fmt.Sprintf("x/%s-%s", exported.ModuleName, icatypes.ModuleName)) | |||
| } | |||
|
|
|||
| // getConnectionID returns the connection id for the given port and channelIDs. | |||
| func (k Keeper) getConnectionID(ctx sdk.Context, portID, channelID string) (string, error) { | |||
There was a problem hiding this comment.
I added this function so that we could verify that connection hops doesn't change.
3 tasks
charleenfei
approved these changes
Jan 5, 2024
DimitrisJim
approved these changes
Jan 8, 2024
colin-axner
reviewed
Jan 8, 2024
colin-axner
approved these changes
Jan 8, 2024
damiannolan
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Thanks @crodriguezvega, LGTM! 🚀
Agree with suggestions from the others :)
DimitrisJim
reviewed
Jan 9, 2024
|
Thank you very much for the reviews everyone, and 💚 🙇 🙏 to @charleenfei for addressing the review comments! |
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* add explicit checks in on chan upgrade try callback of ica host * pr review * Update modules/apps/27-interchain-accounts/host/keeper/handshake.go --------- Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 7a72df0)
crodriguezvega
added a commit
that referenced
this pull request
Jan 9, 2024
#5558) * add explicit checks in on chan upgrade try callback of ica host * pr review * Update modules/apps/27-interchain-accounts/host/keeper/handshake.go --------- Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 7a72df0) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
charleenfei
added a commit
that referenced
this pull request
Jan 11, 2024
* add explicit checks in on chan upgrade try callback of ica host * pr review * Update modules/apps/27-interchain-accounts/host/keeper/handshake.go --------- Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
charleenfei
added a commit
that referenced
this pull request
Jan 11, 2024
* add explicit checks in on chan upgrade try callback of ica host * pr review * Update modules/apps/27-interchain-accounts/host/keeper/handshake.go --------- Co-authored-by: Charly <charly@interchain.io> Co-authored-by: Charly <charly@interchain.berlin> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5462 (comment)
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.