e2e(upgrades): ordered ICA channel can be closed after upgrade and packet timeout

[crodriguezvega]

Description

closes: #5538

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against the correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[DimitrisJim]

lgtm, left one comment re re-using some functions which you probably also noticed.

[DimitrisJim]

also note same e2e is failing for other PRs, seems like a regression someplace (relayer?)

[crodriguezvega]

also note same e2e is failing for other PRs, seems like a regression someplace (relayer?)

I will take a look.

[crodriguezvega]

Looks like in the failing tests the relayer is submitting TRY twice to chain B. I already let Luca know.

[damiannolan]

Is this the PR that requires a new relayer image before merging? I see the test is still failing in CI

[crodriguezvega]

Is this the PR that requires a new relayer image before merging? I see the test is still failing in CI

Correct. Got a new image yesterday, but fails (even though it was passing with the previous image). Already let Luca know.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (310a4bd) 81.49% compared to head (aae7e0f) 81.51%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5537      +/-   ##
==========================================
+ Coverage   81.49%   81.51%   +0.02%     
==========================================
  Files         199      199              
  Lines       15203    15225      +22     
==========================================
+ Hits        12389    12411      +22     
  Misses       2348     2348              
  Partials      466      466              

Files	Coverage Δ
modules/core/04-channel/keeper/keeper.go	90.84% <100.00%> (+0.06%)	⬆️
modules/core/04-channel/keeper/upgrade.go	92.52% <100.00%> (+0.21%)	⬆️

[colin-axner]

Thank you @crodriguezvega for all your works getting the e2e's to be green!!!! ❤️‍🔥