remaining review comments from #1613 #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5539 +/- ##
==========================================
+ Coverage 81.19% 81.22% +0.03%
==========================================
Files 197 197
Lines 15258 15258
==========================================
+ Hits 12388 12394 +6
+ Misses 2405 2399 -6
Partials 465 465
|
9 tasks
added 4 commits
January 10, 2024 22:35
crodriguezvega
requested review from
colin-axner,
AdityaSripal,
damiannolan,
charleenfei,
chatton and
DimitrisJim
as code owners
damiannolan
approved these changes
Jan 15, 2024
Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
DimitrisJim
approved these changes
Jan 16, 2024
colin-axner
approved these changes
Jan 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
* e2e test: send incentivised packet after upgrade, add extra tests for cbs * update hermes docker image * add prune acknowledgements to successful upgrade test * use correct tx response * getting further with the e2e test, addressing a couple of other review items * refactor test to use sync incentivization instead of async * update hermes image tag * revert change that was breaking a test * Apply suggestions from code review Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * rename variables for consistency * rename variables for clarification --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 5d77221) # Conflicts: # e2e/README.md # e2e/tests/core/04-channel/upgrades_test.go # e2e/tests/transfer/incentivized_test.go # e2e/testsuite/grpc_query.go # e2e/testsuite/tx.go
crodriguezvega
pushed a commit
that referenced
this pull request
Jan 16, 2024
* remaining review comments from #1613 (#5539) * e2e test: send incentivised packet after upgrade, add extra tests for cbs * update hermes docker image * add prune acknowledgements to successful upgrade test * use correct tx response * getting further with the e2e test, addressing a couple of other review items * refactor test to use sync incentivization instead of async * update hermes image tag * revert change that was breaking a test * Apply suggestions from code review Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> * rename variables for consistency * rename variables for clarification --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> (cherry picked from commit 5d77221) # Conflicts: # e2e/README.md # e2e/tests/core/04-channel/upgrades_test.go # e2e/tests/transfer/incentivized_test.go # e2e/testsuite/grpc_query.go # e2e/testsuite/tx.go * remove e2e folder --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think this PR covers the remaining comments left in the review of #1613.
The happy path e2e test for channel upgrades now also:
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.