docs: channel upgrade timeout #5546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleenfei
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
damiannolan,
chatton,
DimitrisJim and
srdtrk
as code owners
colin-axner
approved these changes
Jan 8, 2024
…f github.com:cosmos/ibc-go into charly/issue#5268-document-how-upgrade-timeout-works
DimitrisJim
reviewed
Jan 9, 2024
crodriguezvega
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Nice work, @charleenfei! I think we should mention that height-based timeouts are not supported at the moment.
damiannolan
approved these changes
Jan 9, 2024
chatton
approved these changes
Jan 10, 2024
Co-authored-by: Cian Hatton <cian@interchain.io>
crodriguezvega
deleted the
charly/issue#5268-document-how-upgrade-timeout-works
branch
charleenfei
added a commit
that referenced
this pull request
Jan 11, 2024
* upgrade timeout docs * typo * pr review * nit: indentation of code in blocks * Update docs/docs/01-ibc/06-channel-upgrades.md Co-authored-by: Cian Hatton <cian@interchain.io> * review comment: add note about upgrading channels CLI --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Cian Hatton <cian@interchain.io>
charleenfei
added a commit
that referenced
this pull request
Jan 11, 2024
* upgrade timeout docs * typo * pr review * nit: indentation of code in blocks * Update docs/docs/01-ibc/06-channel-upgrades.md Co-authored-by: Cian Hatton <cian@interchain.io> * review comment: add note about upgrading channels CLI --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Cian Hatton <cian@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5268
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.